Page MenuHomePhabricator
Create Task
Maniphest T106096

In Chrome-like browsers, TextInputWidget( { type: 'search' } ) has a curious mix of native and our UI
Closed, ResolvedPublic
Actions

Description

In Chrome-like browsers, TextInputWidget( { type: 'search' } ) has a curious mix of native and our UI.

http://en.wikipedia.beta.wmflabs.org/wiki/Special:Search:

pasted_file (39×706 px, 2 KB)

http://en.wikipedia.beta.wmflabs.org/wiki/Special:Search?useskin=monobook:
pasted_file (50×651 px, 2 KB)

The "x" image on the right is provided by the browser, and empties the text field when clicked (but isn't focusable). We should probably suppress it and replace it with an indicator of our own with the same functionality.

(This widget also has icon: 'search', which should maybe also be implied by type: 'search'?)

Details

SubjectRepoBranchLines +/-
TextInputWidget: Handle type: 'search' betteroojs/uimaster+133 -8
MediaWiki, Apex themes: Add 'clear' indicatoroojs/uimaster+15 -0
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jul 16 2015, 9:50 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2015, 9:50 PM
gerritbot subscribed.Jul 16 2015, 10:20 PM

Change 225252 had a related patch set uploaded (by Bartosz Dziewoński):
Add 'clear' indicator

https://gerrit.wikimedia.org/r/225252

gerritbot added a project: Patch-For-Review.Jul 16 2015, 10:20 PM
gerritbot added a comment.Jul 19 2015, 11:10 PM

Change 225252 merged by jenkins-bot:
MediaWiki, Apex themes: Add 'clear' indicator

https://gerrit.wikimedia.org/r/225252

Jdforrester-WMF assigned this task to matmarex.Jul 19 2015, 11:11 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF mentioned this in rGOJU0f305ea222bd: MediaWiki, Apex themes: Add 'clear' indicator.Jul 19 2015, 11:11 PM
Jdforrester-WMF subscribed.Jul 19 2015, 11:11 PM

Icon now exists, but suppression of the native behaviour not done in that patch.

matmarex lowered the priority of this task from Medium to Low.Jul 20 2015, 7:25 PM
matmarex mentioned this in T106348: Layout of Search field on Special:Search page broken with Safari 9.Jul 20 2015, 8:09 PM
Ricordisamoa subscribed.Jul 20 2015, 8:10 PM
gerritbot added a comment.Jul 21 2015, 1:22 PM

Change 226069 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Handle type: 'search' better

https://gerrit.wikimedia.org/r/226069

gerritbot added a project: Patch-For-Review.Jul 21 2015, 1:22 PM
TheDJ subscribed.Jul 21 2015, 2:59 PM
Jdforrester-WMF closed this task as Resolved.Jul 21 2015, 4:56 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
gerritbot added a comment.Jul 21 2015, 5:00 PM

Change 226069 merged by jenkins-bot:
TextInputWidget: Handle type: 'search' better

https://gerrit.wikimedia.org/r/226069

matmarex mentioned this in rGOJUf3045939cec1: TextInputWidget: Handle type: 'search' better.Jul 21 2015, 5:01 PM
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.12.1); removed OOjs-UI-next-release.Jul 22 2015, 11:44 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL