Page MenuHomePhabricator
Create Task
Maniphest T106171

Validate CPF for AstroPay
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

We should never send an empty or obviously invalid fiscal_number to AstroPay

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/DonationInterfacemaster+0 -11Undo last commit's fiscal number normalization
mediawiki/extensions/DonationInterfacemaster+142 -3Validate fiscal number when exists, require for AstroPay
Customize query in gerrit

Related Objects

Event Timeline

Ejegg created this task.Jul 17 2015, 6:25 PM
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added projects: [DO NOT USE] Astropay [superseded by #FR-Astropay], Fundraising-Backlog.
Ejegg added a subscriber: Ejegg.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 17 2015, 6:25 PM
• atgo triaged this task as Medium priority.Jul 17 2015, 6:33 PM
• atgo moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.
• atgo set Security to None.
gerritbot added a subscriber: gerritbot.Jul 17 2015, 6:36 PM

Change 225349 had a related patch set uploaded (by Ejegg):
WIP Check CPF is numeric when exists, require for AstroPay

https://gerrit.wikimedia.org/r/225349

gerritbot added a project: Patch-For-Review.Jul 17 2015, 6:36 PM
Ejegg added a comment.Jul 17 2015, 6:37 PM

We'll need a new calculated validation function that takes country into account. This table may help: https://en.wikipedia.org/wiki/VAT_identification_number#VAT_numbers_of_Latin_American_countries

• atgo added projects: Fundraising Sprint ODB, Unplanned-Sprint-Work.Jul 17 2015, 6:41 PM
• atgo added a subscriber: • atgo.

While you're in there... T106137? If not, we can hit it in the next sprint.

awight moved this task from Backlog to Doing on the Fundraising Sprint ODB board.Jul 21 2015, 7:33 PM
awight moved this task from Sprint +1 to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Jul 21 2015, 9:53 PM
gerritbot added a comment.Jul 21 2015, 11:11 PM

Change 225349 merged by jenkins-bot:
Validate fiscal number when exists, require for AstroPay

https://gerrit.wikimedia.org/r/225349

Ejegg mentioned this in rMEXT183ca2aae51b: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 21 2015, 11:12 PM
awight mentioned this in rEDOI082a3f507515: Validate fiscal number when exists, require for AstroPay.Jul 21 2015, 11:13 PM
Ejegg moved this task from Doing to Review on the Fundraising Sprint ODB board.Jul 21 2015, 11:29 PM
gerritbot added a comment.Jul 21 2015, 11:32 PM

Change 226248 had a related patch set uploaded (by Ejegg):
Undo last commit's fiscal number normalization

https://gerrit.wikimedia.org/r/226248

gerritbot added a comment.Jul 21 2015, 11:58 PM

Change 226248 merged by jenkins-bot:
Undo last commit's fiscal number normalization

https://gerrit.wikimedia.org/r/226248

Ejegg mentioned this in rMEXTb17a1954646a: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Jul 21 2015, 11:58 PM
Ejegg mentioned this in rEDOI643abbe63700: Undo last commit's fiscal number normalization.
Ejegg moved this task from Review to Pending Deployment on the Fundraising Sprint ODB board.Jul 22 2015, 3:32 PM
Ejegg claimed this task.Jul 22 2015, 7:43 PM
Ejegg updated the task description. (Show Details)
Ejegg added a project: Fundraising Sprint The Pogues.
Ejegg edited a custom field.
Ejegg moved this task from Backlog to Pending Deployment on the Fundraising Sprint The Pogues board.Jul 22 2015, 8:16 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint The Pogues board.Jul 28 2015, 4:17 PM
Ejegg closed this task as Resolved.Jul 28 2015, 8:00 PM
• atgo moved this task from Backlog to Done on the [DO NOT USE] Astropay [superseded by #FR-Astropay] board.Aug 5 2015, 9:39 PM
• DStrine edited a custom field.Aug 18 2015, 3:37 PM
• DStrine edited a custom field.Aug 18 2015, 6:48 PM
• DStrine removed a project: Unplanned-Sprint-Work.Aug 20 2015, 4:53 PM
• DStrine added a project: NewFunctionality-Worktype.Aug 25 2015, 9:23 PM
• DStrine added a project: FR-dlocal.Dec 14 2015, 7:15 PM
• atgo removed a subscriber: • atgo.Mar 30 2016, 10:13 PM
• Phabricator_maintenance removed a project: [DO NOT USE] Astropay [superseded by #FR-Astropay].Aug 10 2016, 11:46 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:40 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL