Page MenuHomePhabricator

Fix easy problems reported by RuboCop in mediawiki/vagrant
Closed, ResolvedPublic

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 226551 had a related patch set uploaded (by Zfilipin):
Run RuboCop in test and gate-and-submit pipelines.

https://gerrit.wikimedia.org/r/226551

Change 226551 merged by jenkins-bot:
Run RuboCop for MW-Vagrant on test and gate-and-submit

https://gerrit.wikimedia.org/r/226551

Change 226564 had a related patch set uploaded (by Dduvall):
Ignore RuboCop violations in upstream code

https://gerrit.wikimedia.org/r/226564

Change 226564 merged by jenkins-bot:
Ignore RuboCop violations in upstream code

https://gerrit.wikimedia.org/r/226564

Change 233366 had a related patch set uploaded (by Zfilipin):
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233366

Change 233366 abandoned by Zfilipin:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233366

Change 233367 had a related patch set uploaded (by Zfilipin):
Fixed Lint/AssignmentInCondition RuboCop offense

https://gerrit.wikimedia.org/r/233367

Change 233368 had a related patch set uploaded (by Zfilipin):
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/233368

Change 233369 had a related patch set uploaded (by Zfilipin):
Fixed Lint/UnusedMethodArgument RuboCop offense

https://gerrit.wikimedia.org/r/233369

Change 233370 had a related patch set uploaded (by Zfilipin):
Fixed Style/AlignParameters RuboCop offense

https://gerrit.wikimedia.org/r/233370

Change 233372 had a related patch set uploaded (by Zfilipin):
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233372

Change 233373 had a related patch set uploaded (by Zfilipin):
Fixed Style/BlockDelimiters RuboCop offense

https://gerrit.wikimedia.org/r/233373

Change 233368 merged by jenkins-bot:
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/233368

Change 233369 merged by jenkins-bot:
Fixed Lint/UnusedMethodArgument RuboCop offense

https://gerrit.wikimedia.org/r/233369

Change 233370 merged by jenkins-bot:
Ignoring Style/AlignParameters RuboCop offenses

https://gerrit.wikimedia.org/r/233370

Change 233372 merged by jenkins-bot:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233372

Change 233373 merged by jenkins-bot:
Fixed Style/BlockDelimiters RuboCop offense

https://gerrit.wikimedia.org/r/233373

Change 233367 merged by jenkins-bot:
Fixed Lint/AssignmentInCondition RuboCop offense

https://gerrit.wikimedia.org/r/233367

Change 234323 had a related patch set uploaded (by Dduvall):
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/234323

Change 234323 merged by jenkins-bot:
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/234323

Change 234496 had a related patch set uploaded (by Zfilipin):
Fixed Style/CaseIndentation RuboCop offense

https://gerrit.wikimedia.org/r/234496

Change 234497 had a related patch set uploaded (by Zfilipin):
Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/234497

Change 234498 had a related patch set uploaded (by Zfilipin):
Fixed Style/DefWithParentheses RuboCop offense

https://gerrit.wikimedia.org/r/234498

Change 234500 had a related patch set uploaded (by Zfilipin):
Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/234500

Change 234501 had a related patch set uploaded (by Zfilipin):
Fixed Style/IfUnlessModifier RuboCop offense

https://gerrit.wikimedia.org/r/234501

Change 234502 had a related patch set uploaded (by Zfilipin):
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/234502

Change 234504 had a related patch set uploaded (by Zfilipin):
Fixed Style/NegatedIf RuboCop offense

https://gerrit.wikimedia.org/r/234504

Change 234496 merged by jenkins-bot:
Fixed Style/CaseIndentation RuboCop offense

https://gerrit.wikimedia.org/r/234496

Change 234497 merged by jenkins-bot:
Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/234497

Change 234498 merged by jenkins-bot:
Fixed Style/DefWithParentheses RuboCop offense

https://gerrit.wikimedia.org/r/234498

Change 234500 merged by jenkins-bot:
Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/234500

Change 234501 merged by jenkins-bot:
Fixed Style/IfUnlessModifier RuboCop offense

https://gerrit.wikimedia.org/r/234501

Change 234502 merged by jenkins-bot:
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/234502

Change 234504 merged by jenkins-bot:
Fixed Style/NegatedIf RuboCop offense

https://gerrit.wikimedia.org/r/234504

Change 240658 had a related patch set uploaded (by Zfilipin):
RuboCop should ignore cache folder

https://gerrit.wikimedia.org/r/240658

Change 240661 had a related patch set uploaded (by Zfilipin):
Fixed Style/WordArray RuboCop offense

https://gerrit.wikimedia.org/r/240661

Change 240662 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingComma RuboCop offense

https://gerrit.wikimedia.org/r/240662

Change 240663 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/240663

Change 240664 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/240664

Change 240658 merged by jenkins-bot:
RuboCop should ignore cache folder

https://gerrit.wikimedia.org/r/240658

Change 240661 merged by jenkins-bot:
Ignore Style/WordArray RuboCop offense

https://gerrit.wikimedia.org/r/240661

Change 240663 merged by jenkins-bot:
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/240663

Change 240664 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/240664

Change 240662 abandoned by Zfilipin:
Fixed Style/TrailingComma RuboCop offense

https://gerrit.wikimedia.org/r/240662

Change 250407 had a related patch set uploaded (by Zfilipin):
Fixed Style/NumericLiterals RubCop offense

https://gerrit.wikimedia.org/r/250407

Change 250408 had a related patch set uploaded (by Zfilipin):
Fixed Style/PerlBackrefs RuboCop offence

https://gerrit.wikimedia.org/r/250408

Change 250409 had a related patch set uploaded (by Zfilipin):
Fixed Style/RedundantBegin RuboCop offense

https://gerrit.wikimedia.org/r/250409

Change 250410 had a related patch set uploaded (by Zfilipin):
Fixed Style/RedundantSelf RuboCop offence

https://gerrit.wikimedia.org/r/250410

Change 250411 had a related patch set uploaded (by Zfilipin):
Fixed Style/Semicolon RuboCop offense

https://gerrit.wikimedia.org/r/250411

Change 250407 merged by jenkins-bot:
Ignore Style/NumericLiterals RubCop offense

https://gerrit.wikimedia.org/r/250407

Change 250408 merged by jenkins-bot:
Fixed Style/PerlBackrefs RuboCop offence

https://gerrit.wikimedia.org/r/250408

Change 250409 merged by jenkins-bot:
Fixed Style/RedundantBegin RuboCop offense

https://gerrit.wikimedia.org/r/250409

Change 250410 merged by jenkins-bot:
Fixed Style/RedundantSelf RuboCop offence

https://gerrit.wikimedia.org/r/250410

Change 250411 merged by jenkins-bot:
Fixed Style/Semicolon RuboCop offense

https://gerrit.wikimedia.org/r/250411

Change 252666 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAfterComma RuboCop offense

https://gerrit.wikimedia.org/r/252666

Change 252667 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/252667

Change 252668 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/252668

Change 252669 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpecialGlobalVars RuboCop offense

https://gerrit.wikimedia.org/r/252669

Change 252675 had a related patch set uploaded (by Zfilipin):
Fixed Style/Next RuboCop offense

https://gerrit.wikimedia.org/r/252675

Change 252677 had a related patch set uploaded (by Zfilipin):
Fixed Style/RescueModifier RuboCop offense

https://gerrit.wikimedia.org/r/252677

Change 252678 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingComma RuboCop offense

https://gerrit.wikimedia.org/r/252678

Change 252666 merged by jenkins-bot:
Fixed Style/SpaceAfterComma RuboCop offense

https://gerrit.wikimedia.org/r/252666

Change 252667 merged by jenkins-bot:
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/252667

Change 252668 merged by jenkins-bot:
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/252668

Change 252678 abandoned by Dduvall:
Fixed Style/TrailingComma RuboCop offense

Reason:
We're going to ignore this rule on account of its bugginess.

https://gerrit.wikimedia.org/r/252678

Change 252669 merged by jenkins-bot:
Fixed Style/SpecialGlobalVars RuboCop offense

https://gerrit.wikimedia.org/r/252669

Change 252675 merged by jenkins-bot:
Fixed Style/Next RuboCop offense

https://gerrit.wikimedia.org/r/252675

Change 252677 abandoned by Dduvall:
Fixed Style/RescueModifier RuboCop offense

Reason:
Looks like while we were rebasing, this got incorporated somehow into the previous commit.

https://gerrit.wikimedia.org/r/252677

zeljkofilipin removed zeljkofilipin as the assignee of this task.Nov 23 2015, 11:49 AM
zeljkofilipin removed a project: Patch-For-Review.
zeljkofilipin moved this task from Awaiting review to Backlog on the MediaWiki-Vagrant board.
hashar closed this task as Resolved.Feb 16 2016, 2:37 PM
hashar claimed this task.
hashar added a subscriber: hashar.

A bulk of ruby style changes have been merged in mediawiki/vagrant. The .rubocop_todo.yml is small enough that I am being bold and consider this task "fix easy problem" as solved.

hashar reassigned this task from hashar to zeljkofilipin.Feb 16 2016, 2:37 PM