Page MenuHomePhabricator
Create Task
Maniphest T106220

Fix easy problems reported by RuboCop in mediawiki/vagrant
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Fixed Style/SpecialGlobalVars RuboCop offensemediawiki/vagrantmaster+5 -13
Fixed Style/RescueModifier RuboCop offensemediawiki/vagrantmaster+13 -13
Fixed Style/Next RuboCop offensemediawiki/vagrantmaster+22 -32
Fixed Style/TrailingComma RuboCop offensemediawiki/vagrantmaster+13 -20
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offensemediawiki/vagrantmaster+1 -7
Fixed Style/SpaceAroundOperators RuboCop offensemediawiki/vagrantmaster+3 -12
Fixed Style/SpaceAfterComma RuboCop offensemediawiki/vagrantmaster+4 -12
Fixed Style/Semicolon RuboCop offensemediawiki/vagrantmaster+1 -8
Fixed Style/RedundantSelf RuboCop offencemediawiki/vagrantmaster+1 -7
Fixed Style/RedundantBegin RuboCop offensemediawiki/vagrantmaster+17 -23
Fixed Style/PerlBackrefs RuboCop offencemediawiki/vagrantmaster+1 -7
Ignore Style/NumericLiterals RubCop offensemediawiki/vagrantmaster+3 -5
Fixed Style/TrailingComma RuboCop offensemediawiki/vagrantmaster+11 -18
Fixed Style/StringLiterals RuboCop offensemediawiki/vagrantmaster+79 -85
Fixed Style/TrailingBlankLines RuboCop offensemediawiki/vagrantmaster+0 -12
Ignore Style/WordArray RuboCop offensemediawiki/vagrantmaster+3 -6
RuboCop should ignore cache foldermediawiki/vagrantmaster+1 -0
Fixed Style/NegatedIf RuboCop offensemediawiki/vagrantmaster+10 -15
Fixed Style/LeadingCommentSpace RuboCop offensemediawiki/vagrantmaster+1 -6
Fixed Style/IfUnlessModifier RuboCop offensemediawiki/vagrantmaster+3 -15
Fixed Style/HashSyntax RuboCop offensemediawiki/vagrantmaster+14 -20
Fixed Style/DefWithParentheses RuboCop offensemediawiki/vagrantmaster+5 -10
Fixed Style/CommentAnnotation RuboCop offensemediawiki/vagrantmaster+2 -8
Fixed Style/CaseIndentation RuboCop offensemediawiki/vagrantmaster+5 -11
Fixed Style/IndentationWidth RuboCop offensemediawiki/vagrantmaster+217 -223
Fixed Lint/AssignmentInCondition RuboCop offensemediawiki/vagrantmaster+4 -11
Fixed Style/BlockDelimiters RuboCop offensemediawiki/vagrantmaster+15 -19
Fixed RuboCop Style/AndOr offensemediawiki/vagrantmaster+4 -10
Ignoring Style/AlignParameters RuboCop offensesmediawiki/vagrantmaster+5 -6
Fixed Lint/UnusedMethodArgument RuboCop offensemediawiki/vagrantmaster+5 -10
Fixed Lint/UnusedBlockArgument RuboCop offensemediawiki/vagrantmaster+43 -48
Fixed RuboCop Style/AndOr offensemediawiki/vagrantmaster+3 -9
Ignore RuboCop violations in upstream codemediawiki/vagrantmaster+44 -127
Run RuboCop for MW-Vagrant on test and gate-and-submitintegration/configmaster+2 -2
Fixed Style/SpaceAfterNot RuboCop offensemediawiki/vagrantmaster+1 -6
Fixed Style/ColonMethodCall RuboCop offensemediawiki/vagrantmaster+1 -6
Fixed Style/TrailingWhitespace RuboCop offensemediawiki/vagrantmaster+11 -16
Updated RuboCop to the latest versionmediawiki/vagrantmaster+151 -224
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Jul 23 2015, 4:29 PM

Change 226551 had a related patch set uploaded (by Zfilipin):
Run RuboCop in test and gate-and-submit pipelines.

https://gerrit.wikimedia.org/r/226551

gerritbot added a comment.Jul 23 2015, 4:37 PM

Change 226551 merged by jenkins-bot:
Run RuboCop for MW-Vagrant on test and gate-and-submit

https://gerrit.wikimedia.org/r/226551

• dduvall mentioned this in rCICF97b528eaa8c0: Run RuboCop for MW-Vagrant on test and gate-and-submit.Jul 23 2015, 4:38 PM
gerritbot added a comment.Jul 23 2015, 5:15 PM

Change 226564 had a related patch set uploaded (by Dduvall):
Ignore RuboCop violations in upstream code

https://gerrit.wikimedia.org/r/226564

gerritbot added a comment.Jul 23 2015, 6:27 PM

Change 226564 merged by jenkins-bot:
Ignore RuboCop violations in upstream code

https://gerrit.wikimedia.org/r/226564

• dduvall mentioned this in rMWVA57fd9fed0906: Ignore RuboCop violations in upstream code.Jul 23 2015, 6:28 PM
gerritbot added a comment.Aug 24 2015, 9:27 AM

Change 233366 had a related patch set uploaded (by Zfilipin):
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233366

gerritbot added a comment.Aug 24 2015, 9:32 AM

Change 233366 abandoned by Zfilipin:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233366

gerritbot added a comment.Aug 24 2015, 9:35 AM

Change 233367 had a related patch set uploaded (by Zfilipin):
Fixed Lint/AssignmentInCondition RuboCop offense

https://gerrit.wikimedia.org/r/233367

gerritbot added a comment.Aug 24 2015, 9:41 AM

Change 233368 had a related patch set uploaded (by Zfilipin):
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/233368

gerritbot added a comment.Aug 24 2015, 9:47 AM

Change 233369 had a related patch set uploaded (by Zfilipin):
Fixed Lint/UnusedMethodArgument RuboCop offense

https://gerrit.wikimedia.org/r/233369

gerritbot added a comment.Aug 24 2015, 9:50 AM

Change 233370 had a related patch set uploaded (by Zfilipin):
Fixed Style/AlignParameters RuboCop offense

https://gerrit.wikimedia.org/r/233370

gerritbot added a comment.Aug 24 2015, 9:55 AM

Change 233372 had a related patch set uploaded (by Zfilipin):
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233372

gerritbot added a comment.Aug 24 2015, 9:58 AM

Change 233373 had a related patch set uploaded (by Zfilipin):
Fixed Style/BlockDelimiters RuboCop offense

https://gerrit.wikimedia.org/r/233373

• dduvall moved this task from Backlog to In Progress on the MediaWiki-Vagrant board.Aug 27 2015, 4:09 PM
gerritbot added a comment.Aug 27 2015, 4:50 PM

Change 233368 merged by jenkins-bot:
Fixed Lint/UnusedBlockArgument RuboCop offense

https://gerrit.wikimedia.org/r/233368

gerritbot added a comment.Aug 27 2015, 4:50 PM

Change 233369 merged by jenkins-bot:
Fixed Lint/UnusedMethodArgument RuboCop offense

https://gerrit.wikimedia.org/r/233369

gerritbot added a comment.Aug 27 2015, 4:51 PM

Change 233370 merged by jenkins-bot:
Ignoring Style/AlignParameters RuboCop offenses

https://gerrit.wikimedia.org/r/233370

gerritbot added a comment.Aug 27 2015, 4:51 PM

Change 233372 merged by jenkins-bot:
Fixed RuboCop Style/AndOr offense

https://gerrit.wikimedia.org/r/233372

gerritbot added a comment.Aug 27 2015, 4:52 PM

Change 233373 merged by jenkins-bot:
Fixed Style/BlockDelimiters RuboCop offense

https://gerrit.wikimedia.org/r/233373

• dduvall mentioned this in rMWVAd4cbb9895956: Fixed Lint/UnusedMethodArgument RuboCop offense.Aug 27 2015, 4:52 PM
• dduvall mentioned this in rMWVA60ef0bfe63d7: Fixed Lint/UnusedBlockArgument RuboCop offense.
• dduvall mentioned this in rMWVA6aad9a082ad9: Ignoring Style/AlignParameters RuboCop offenses.
• dduvall mentioned this in rMWVAde7b7ed632fb: Fixed RuboCop Style/AndOr offense.
• dduvall mentioned this in rMWVA9a696e8a41fa: Fixed Style/BlockDelimiters RuboCop offense.
gerritbot added a comment.Aug 27 2015, 5:04 PM

Change 233367 merged by jenkins-bot:
Fixed Lint/AssignmentInCondition RuboCop offense

https://gerrit.wikimedia.org/r/233367

• dduvall mentioned this in rMWVA6245474b2ab6: Fixed Lint/AssignmentInCondition RuboCop offense.Aug 27 2015, 5:04 PM
gerritbot added a comment.Aug 27 2015, 5:39 PM

Change 234323 had a related patch set uploaded (by Dduvall):
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/234323

gerritbot added a comment.Aug 28 2015, 11:03 AM

Change 234323 merged by jenkins-bot:
Fixed Style/IndentationWidth RuboCop offense

https://gerrit.wikimedia.org/r/234323

• dduvall mentioned this in rMWVA622de988b609: Fixed Style/IndentationWidth RuboCop offense.Aug 28 2015, 11:03 AM
gerritbot added a comment.Aug 28 2015, 11:08 AM

Change 234496 had a related patch set uploaded (by Zfilipin):
Fixed Style/CaseIndentation RuboCop offense

https://gerrit.wikimedia.org/r/234496

gerritbot added a comment.Aug 28 2015, 11:09 AM

Change 234497 had a related patch set uploaded (by Zfilipin):
Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/234497

gerritbot added a comment.Aug 28 2015, 11:10 AM

Change 234498 had a related patch set uploaded (by Zfilipin):
Fixed Style/DefWithParentheses RuboCop offense

https://gerrit.wikimedia.org/r/234498

gerritbot added a comment.Aug 28 2015, 11:19 AM

Change 234500 had a related patch set uploaded (by Zfilipin):
Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/234500

gerritbot added a comment.Aug 28 2015, 11:20 AM

Change 234501 had a related patch set uploaded (by Zfilipin):
Fixed Style/IfUnlessModifier RuboCop offense

https://gerrit.wikimedia.org/r/234501

gerritbot added a comment.Aug 28 2015, 11:21 AM

Change 234502 had a related patch set uploaded (by Zfilipin):
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/234502

gerritbot added a comment.Aug 28 2015, 11:23 AM

Change 234504 had a related patch set uploaded (by Zfilipin):
Fixed Style/NegatedIf RuboCop offense

https://gerrit.wikimedia.org/r/234504

gerritbot added a comment.Sep 9 2015, 10:34 PM

Change 234496 merged by jenkins-bot:
Fixed Style/CaseIndentation RuboCop offense

https://gerrit.wikimedia.org/r/234496

bd808 mentioned this in rMWVAacafd9f7878f: Fixed Style/CaseIndentation RuboCop offense.Sep 9 2015, 10:34 PM
gerritbot added a comment.Sep 9 2015, 10:35 PM

Change 234497 merged by jenkins-bot:
Fixed Style/CommentAnnotation RuboCop offense

https://gerrit.wikimedia.org/r/234497

bd808 mentioned this in rMWVA1d8a1fbe6d3a: Fixed Style/CommentAnnotation RuboCop offense.Sep 9 2015, 10:35 PM
gerritbot added a comment.Sep 9 2015, 10:36 PM

Change 234498 merged by jenkins-bot:
Fixed Style/DefWithParentheses RuboCop offense

https://gerrit.wikimedia.org/r/234498

bd808 mentioned this in rMWVA2d18fe5d3c52: Fixed Style/DefWithParentheses RuboCop offense.Sep 9 2015, 10:36 PM
zeljkofilipin mentioned this in T91485: Fix easy problems reported by RuboCop.Sep 11 2015, 3:28 PM
zeljkofilipin moved this task from In Progress to Awaiting review on the MediaWiki-Vagrant board.Sep 22 2015, 8:37 PM
gerritbot added a comment.Sep 24 2015, 12:00 AM

Change 234500 merged by jenkins-bot:
Fixed Style/HashSyntax RuboCop offense

https://gerrit.wikimedia.org/r/234500

• dduvall mentioned this in rMWVAb21196262561: Fixed Style/HashSyntax RuboCop offense.Sep 24 2015, 12:00 AM
gerritbot added a comment.Sep 24 2015, 12:00 AM

Change 234501 merged by jenkins-bot:
Fixed Style/IfUnlessModifier RuboCop offense

https://gerrit.wikimedia.org/r/234501

gerritbot added a comment.Sep 24 2015, 12:01 AM

Change 234502 merged by jenkins-bot:
Fixed Style/LeadingCommentSpace RuboCop offense

https://gerrit.wikimedia.org/r/234502

gerritbot added a comment.Sep 24 2015, 12:01 AM

Change 234504 merged by jenkins-bot:
Fixed Style/NegatedIf RuboCop offense

https://gerrit.wikimedia.org/r/234504

• dduvall mentioned this in rMWVA592f8e37f86f: Fixed Style/IfUnlessModifier RuboCop offense.Sep 24 2015, 12:01 AM
• dduvall mentioned this in rMWVA3d7f08602222: Fixed Style/LeadingCommentSpace RuboCop offense.
• dduvall mentioned this in rMWVAbe22a196b8ad: Fixed Style/NegatedIf RuboCop offense.
gerritbot added a comment.Sep 24 2015, 9:51 AM

Change 240658 had a related patch set uploaded (by Zfilipin):
RuboCop should ignore cache folder

https://gerrit.wikimedia.org/r/240658

gerritbot added a comment.Sep 24 2015, 9:58 AM

Change 240661 had a related patch set uploaded (by Zfilipin):
Fixed Style/WordArray RuboCop offense

https://gerrit.wikimedia.org/r/240661

gerritbot added a comment.Sep 24 2015, 9:58 AM

Change 240662 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingComma RuboCop offense

https://gerrit.wikimedia.org/r/240662

gerritbot added a comment.Sep 24 2015, 9:58 AM

Change 240663 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/240663

gerritbot added a comment.Sep 24 2015, 9:58 AM

Change 240664 had a related patch set uploaded (by Zfilipin):
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/240664

gerritbot added a comment.Sep 29 2015, 10:59 AM

Change 240658 merged by jenkins-bot:
RuboCop should ignore cache folder

https://gerrit.wikimedia.org/r/240658

zeljkofilipin mentioned this in rMWVA4ac893a21ffd: RuboCop should ignore cache folder.Sep 29 2015, 11:23 AM
gerritbot added a comment.Oct 12 2015, 2:41 PM

Change 240661 merged by jenkins-bot:
Ignore Style/WordArray RuboCop offense

https://gerrit.wikimedia.org/r/240661

gerritbot added a comment.Oct 13 2015, 9:39 AM

Change 240663 merged by jenkins-bot:
Fixed Style/TrailingBlankLines RuboCop offense

https://gerrit.wikimedia.org/r/240663

gerritbot added a comment.Oct 15 2015, 4:15 PM

Change 240664 merged by jenkins-bot:
Fixed Style/StringLiterals RuboCop offense

https://gerrit.wikimedia.org/r/240664

gerritbot added a comment.Oct 15 2015, 4:22 PM

Change 240662 abandoned by Zfilipin:
Fixed Style/TrailingComma RuboCop offense

https://gerrit.wikimedia.org/r/240662

zeljkofilipin moved this task from Awaiting review to In Progress on the MediaWiki-Vagrant board.Nov 2 2015, 12:21 PM
gerritbot added a comment.Nov 2 2015, 12:27 PM

Change 250407 had a related patch set uploaded (by Zfilipin):
Fixed Style/NumericLiterals RubCop offense

https://gerrit.wikimedia.org/r/250407

gerritbot added a comment.Nov 2 2015, 12:33 PM

Change 250408 had a related patch set uploaded (by Zfilipin):
Fixed Style/PerlBackrefs RuboCop offence

https://gerrit.wikimedia.org/r/250408

gerritbot added a comment.Nov 2 2015, 12:33 PM

Change 250409 had a related patch set uploaded (by Zfilipin):
Fixed Style/RedundantBegin RuboCop offense

https://gerrit.wikimedia.org/r/250409

gerritbot added a comment.Nov 2 2015, 12:33 PM

Change 250410 had a related patch set uploaded (by Zfilipin):
Fixed Style/RedundantSelf RuboCop offence

https://gerrit.wikimedia.org/r/250410

gerritbot added a comment.Nov 2 2015, 12:33 PM

Change 250411 had a related patch set uploaded (by Zfilipin):
Fixed Style/Semicolon RuboCop offense

https://gerrit.wikimedia.org/r/250411

zeljkofilipin moved this task from In Progress to Awaiting review on the MediaWiki-Vagrant board.Nov 2 2015, 12:34 PM
Liuxinyu970226 set Security to None.Nov 8 2015, 10:23 AM
zeljkofilipin added a project: Ruby.Nov 9 2015, 3:10 PM
gerritbot added a comment.Nov 10 2015, 2:29 PM

Change 250407 merged by jenkins-bot:
Ignore Style/NumericLiterals RubCop offense

https://gerrit.wikimedia.org/r/250407

gerritbot added a comment.Nov 10 2015, 2:34 PM

Change 250408 merged by jenkins-bot:
Fixed Style/PerlBackrefs RuboCop offence

https://gerrit.wikimedia.org/r/250408

gerritbot added a comment.Nov 10 2015, 2:35 PM

Change 250409 merged by jenkins-bot:
Fixed Style/RedundantBegin RuboCop offense

https://gerrit.wikimedia.org/r/250409

gerritbot added a comment.Nov 10 2015, 2:35 PM

Change 250410 merged by jenkins-bot:
Fixed Style/RedundantSelf RuboCop offence

https://gerrit.wikimedia.org/r/250410

gerritbot added a comment.Nov 10 2015, 2:35 PM

Change 250411 merged by jenkins-bot:
Fixed Style/Semicolon RuboCop offense

https://gerrit.wikimedia.org/r/250411

gerritbot added a comment.Nov 12 2015, 11:39 AM

Change 252666 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAfterComma RuboCop offense

https://gerrit.wikimedia.org/r/252666

gerritbot added a comment.Nov 12 2015, 11:44 AM

Change 252667 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/252667

gerritbot added a comment.Nov 12 2015, 11:44 AM

Change 252668 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/252668

gerritbot added a comment.Nov 12 2015, 11:44 AM

Change 252669 had a related patch set uploaded (by Zfilipin):
Fixed Style/SpecialGlobalVars RuboCop offense

https://gerrit.wikimedia.org/r/252669

gerritbot added a comment.Nov 12 2015, 12:03 PM

Change 252675 had a related patch set uploaded (by Zfilipin):
Fixed Style/Next RuboCop offense

https://gerrit.wikimedia.org/r/252675

gerritbot added a comment.Nov 12 2015, 12:18 PM

Change 252677 had a related patch set uploaded (by Zfilipin):
Fixed Style/RescueModifier RuboCop offense

https://gerrit.wikimedia.org/r/252677

gerritbot added a comment.Nov 12 2015, 12:18 PM

Change 252678 had a related patch set uploaded (by Zfilipin):
Fixed Style/TrailingComma RuboCop offense

https://gerrit.wikimedia.org/r/252678

gerritbot added a comment.Nov 12 2015, 3:17 PM

Change 252666 merged by jenkins-bot:
Fixed Style/SpaceAfterComma RuboCop offense

https://gerrit.wikimedia.org/r/252666

gerritbot added a comment.Nov 12 2015, 3:17 PM

Change 252667 merged by jenkins-bot:
Fixed Style/SpaceAroundOperators RuboCop offense

https://gerrit.wikimedia.org/r/252667

gerritbot added a comment.Nov 12 2015, 3:19 PM

Change 252668 merged by jenkins-bot:
Fixed Style/SpaceInsideHashLiteralBraces RuboCop offense

https://gerrit.wikimedia.org/r/252668

gerritbot added a comment.Nov 20 2015, 5:51 PM

Change 252678 abandoned by Dduvall:
Fixed Style/TrailingComma RuboCop offense

Reason:
We're going to ignore this rule on account of its bugginess.

https://gerrit.wikimedia.org/r/252678

gerritbot added a comment.Nov 20 2015, 5:55 PM

Change 252669 merged by jenkins-bot:
Fixed Style/SpecialGlobalVars RuboCop offense

https://gerrit.wikimedia.org/r/252669

gerritbot added a comment.Nov 20 2015, 5:55 PM

Change 252675 merged by jenkins-bot:
Fixed Style/Next RuboCop offense

https://gerrit.wikimedia.org/r/252675

gerritbot added a comment.Nov 20 2015, 9:13 PM

Change 252677 abandoned by Dduvall:
Fixed Style/RescueModifier RuboCop offense

Reason:
Looks like while we were rebasing, this got incorporated somehow into the previous commit.

https://gerrit.wikimedia.org/r/252677

zeljkofilipin removed zeljkofilipin as the assignee of this task.Nov 23 2015, 11:49 AM
zeljkofilipin removed a project: Patch-For-Review.
zeljkofilipin moved this task from Awaiting review to Backlog on the MediaWiki-Vagrant board.
hashar closed this task as Resolved.Feb 16 2016, 2:37 PM
hashar claimed this task.
hashar subscribed.

A bulk of ruby style changes have been merged in mediawiki/vagrant. The .rubocop_todo.yml is small enough that I am being bold and consider this task "fix easy problem" as solved.

hashar reassigned this task from hashar to zeljkofilipin.Feb 16 2016, 2:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL