Page MenuHomePhabricator
Create Task
Maniphest T106276

Certain Memcached keys are retrieved multiple times for a single page view
Open, Needs TriagePublic
Actions

Description

In the course of attempting to isolate an unrelated problem, I noticed that certain memcached keys were being retrieved multiple times in a single request. The specific request was parsing [[en:United States]]. I saw the following keys retrieved multiple times:

Times retrievedMemcached key
6getMulti(WANCache:v:enwiki:user:id:292262)
6get(centralauth-user-37df0dd0caf3ce2dd4d955209bdaccc5)
4get(enwiki:echo-notification-count:292262:1.5)

Related Objects

Event Timeline

ori created this task.Jul 19 2015, 3:52 PM
ori raised the priority of this task from to Needs Triage.
ori updated the task description. (Show Details)
ori added projects: MediaWiki-extensions-CentralAuth, Performance Issue, Notifications (Echo).
ori added subscribers: ori, Legoktm, aaron.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJul 19 2015, 3:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm added a comment.Jul 21 2015, 9:15 PM

By parse do you mean just parsing (e.g. api.php?action=parse) or parsing the page and re-generating various skin/UI elements?

Also, is there a way I can reproduce this myself?

Legoktm added a comment.Jul 22 2015, 12:08 AM

rECHO6515e1fd6599: Avoid an extra memcached lookup in MWEchoNotifUser::getNotificationCount() will cut the echo-notification-count keys in half.

• DannyH removed projects: Notifications (Echo), Collaboration-Team-Triage.Jul 29 2015, 11:57 PM
• DannyH set Security to None.
Krinkle mentioned this in T252244: CentralAuth extension: Code stewardship review.May 8 2020, 8:20 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits