⚓ T106325 Disallow typing newlines in the edit summary in VisualEditor

	Subject	Repo	Branch	Lines +/-
	Disallow typing newlines in the edit summary	mediawiki/extensions/VisualEditor	master	+17 -7

		Status	Subtype	Assigned	Task
		Declined		matmarex	T54133 VisualEditor: Edit summary box should be a text input box and not textarea
		Resolved		matmarex	T106325 Disallow typing newlines in the edit summary in VisualEditor

matmarex created this task.Jul 20 2015, 11:25 AM

matmarex raised the priority of this task from to Needs Triage.

matmarex updated the task description. (Show Details)

matmarex added projects: VisualEditor, VisualEditor-MediaWiki.

matmarex subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2015, 11:25 AM

matmarex added a parent task: T54133: VisualEditor: Edit summary box should be a text input box and not textarea.Jul 20 2015, 11:25 AM

I've already written the code for this when playing with T54133, let's port it over.

Change 225861 had a related patch set uploaded (by Bartosz Dziewoński):
Disallow typing newlines in the edit summary

https://gerrit.wikimedia.org/r/225861

gerritbot added a project: Patch-For-Review.Jul 20 2015, 12:00 PM

• MZMcBride subscribed.Jul 20 2015, 12:34 PM

Ricordisamoa subscribed.Jul 20 2015, 12:54 PM

to match MediaWiki's behavior

Actually, in source editing mode, pressing the Enter key saves the page.

Yeah, the difference is intentional (maybe I didn't say it very well, feel free to amend the commit message). As discussed previously somewhere on the related tasks, the VE edit summary input field "looks" multiline and Enter saving the page could be surprising (and especially annoying since you can't correct the summary later).

matmarex triaged this task as Medium priority.Jul 20 2015, 7:25 PM

Change 225861 merged by jenkins-bot:
Disallow typing newlines in the edit summary

https://gerrit.wikimedia.org/r/225861

matmarex mentioned this in rEVED9134ec2d73b7: Disallow typing newlines in the edit summary.Jul 20 2015, 7:36 PM

• Forrestbot added a project: WMF-deploy-2015-07-21_(1.26wmf15).Jul 20 2015, 8:00 PM

Esanders closed this task as Resolved.Jul 20 2015, 10:23 PM

Esanders subscribed.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 21 2015, 8:42 PM

• Elitre subscribed.Jul 22 2015, 2:55 PM

Jdforrester-WMF set Security to None.Aug 5 2015, 1:37 AM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM