Page MenuHomePhabricator

Disallow typing newlines in the edit summary in VisualEditor
Closed, ResolvedPublic8 Story Points

Description

We should make it impossible to type newlines in the edit summary in VisualEditor, to match MediaWiki's behavior. Edit summaries are single-line and any newlines that accidentally get there are not rendered anyway. (Vaguely related: T106259)

Event Timeline

matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a subscriber: matmarex.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 20 2015, 11:25 AM

I've already written the code for this when playing with T54133, let's port it over.

Change 225861 had a related patch set uploaded (by Bartosz Dziewoński):
Disallow typing newlines in the edit summary

https://gerrit.wikimedia.org/r/225861

to match MediaWiki's behavior

Actually, in source editing mode, pressing the Enter key saves the page.

Yeah, the difference is intentional (maybe I didn't say it very well, feel free to amend the commit message). As discussed previously somewhere on the related tasks, the VE edit summary input field "looks" multiline and Enter saving the page could be surprising (and especially annoying since you can't correct the summary later).

matmarex triaged this task as Normal priority.Jul 20 2015, 7:25 PM

Change 225861 merged by jenkins-bot:
Disallow typing newlines in the edit summary

https://gerrit.wikimedia.org/r/225861

Esanders closed this task as Resolved.Jul 20 2015, 10:23 PM
Esanders added a subscriber: Esanders.
Elitre added a subscriber: Elitre.Jul 22 2015, 2:55 PM
Jdforrester-WMF edited a custom field.