Page MenuHomePhabricator

Layout of Search field on Special:Search page broken with Safari 9
Closed, ResolvedPublic

Description

On Safari 9, this field now looks like:

Screen Shot 2015-07-20 at 22.02.52.png (133×833 px, 20 KB)

https://en.wikipedia.org/w/index.php?title=Special:Search

Event Timeline

TheDJ raised the priority of this task from to Needs Triage.
TheDJ updated the task description. (Show Details)
TheDJ subscribed.

Welp, that is mightly silly. As a wild guess, Safari is ignoring our styles for the field because it is <input type=search />? This looks like a worse variant of T106096 (which is this, but in Chrome).

Can you see if removing 'type' => 'search', from SpecialSearch::shortDialog() fixes it? If yes, we should do that.

matmarex set Security to None.

Resetting the built in CSS with: -webkit-appearance: textfield; or -webkit-appearance: none; seems to work.

Looking at this bug together with T106096, I think we should just disallow type: 'search' config for TextInputWidget, and make a SearchTextInputWidget (SearchInputWidget?) with the fancier custom UI with "clear" button/indicator and type=search + -webkit-appearance: textfield; for semantic goodness.

Eh, actually, that would be somewhat inconvenient.

Not really related to this task but is anything supposed to happen when you click on the icon? When I hover over it, the cursor changes to a pointer giving the expectation that something's supposed to happen when I click on it. However, nothing happens. This seems like broken behavior to me.

Thanks for filing this task. This is happening in Safari 7 as well. (I noticed this issue when debugging a separate search input + layout bug in Safari, but I didn't have time to investigate fully.)

Change 226069 had a related patch set uploaded (by Bartosz Dziewoński):
TextInputWidget: Handle type: 'search' better

https://gerrit.wikimedia.org/r/226069

Not really related to this task but is anything supposed to happen when you click on the icon? When I hover over it, the cursor changes to a pointer giving the expectation that something's supposed to happen when I click on it. However, nothing happens. This seems like broken behavior to me.

That was T98213 and was just recently fixed. The icon indeed does nothing, it's just an icon.

Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.

Change 226069 merged by jenkins-bot:
TextInputWidget: Handle type: 'search' better

https://gerrit.wikimedia.org/r/226069