Page MenuHomePhabricator
Create Task
Maniphest T106367

Generate BCP 47 conform language codes for the HTML attribute `lang`
Closed, ResolvedPublic
Actions

Description

MediaWiki currently generates for the HTML attribute lang some language codes which are not conform to BCP 47:

I suggest the following replacements:

  • de-formal -> de or de-x-formal
  • en-rtl -> en
  • nl-informal -> nl or nl-x-informal

simple is already converted to en. So here is nothing to do: https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.mediawiki.org%2Fwiki%2FSpecial%3ASpecialPages%3Fuselang%3Dsimple

Details

SubjectRepoBranchLines +/-
Ensure LanguageCode::bcp47() returns a valid BCP 47 language codemediawiki/coremaster+212 -27
Ensure LanguageCode::bcp47() returns a valid BCP 47 language codemediawiki/coremaster+213 -27
Substitute language codes that are not conform to BCP 47mediawiki/coremaster+37 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Fomafix created this task.Jul 21 2015, 7:17 AM
Fomafix claimed this task.
Fomafix raised the priority of this task from to Medium.
Fomafix updated the task description. (Show Details)
Fomafix added a project: MediaWiki-Internationalization.
Fomafix subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2015, 7:17 AM
gerritbot subscribed.Jul 21 2015, 7:21 AM

Change 226040 had a related patch set uploaded (by Gerrit Patch Uploader):
GlobalFunctions.php: Generate BCP 47 conform language codes

https://gerrit.wikimedia.org/r/226040

gerritbot added a project: Patch-For-Review.Jul 21 2015, 7:21 AM
Fomafix mentioned this in T105430: [Task] Ensure that language tags generated in RDF output are standard language names .Jul 21 2015, 7:23 AM
Fomafix added a comment.Jul 24 2015, 5:13 AM

de-formal and nl-informal can also mapped to de and nl for the HTML attribute lang.

• Jonas subscribed.Aug 24 2015, 12:13 PM

In wikibase there is a workaround for this [T105430], because we need a unique language code for each wiki. Once this is done we should use this to get rid of our workaround.

• Jonas added a project: Wikidata.Aug 24 2015, 12:13 PM
• Jonas set Security to None.
• Jonas moved this task from incoming to monitoring on the Wikidata board.
Fomafix reopened this task as Open.Jul 4 2017, 5:55 AM
Fomafix closed this task as a duplicate of T152050: "de-formal" is no valid HTML language code.
Fomafix merged a task: T152050: "de-formal" is no valid HTML language code.
Fomafix added a subscriber: Phispi.
Fomafix added a parent task: T2209: [DO NOT USE] HTML validity (tracking).Jul 4 2017, 2:47 PM
Liuxinyu970226 subscribed.Dec 25 2017, 1:29 AM
Volker_E subscribed.Mar 30 2018, 4:55 PM
Fomafix renamed this task from Generate BCP 47 conform language codes to Generate BCP 47 conform language codes for the HTML attribute `lang`.Mar 30 2018, 8:24 PM
Fomafix updated the task description. (Show Details)
Fomafix mentioned this in T120847: Use BCP 47 conform language codes for the HTML attribute lang.Apr 1 2018, 9:08 AM
gerritbot added a comment.Jun 29 2018, 6:38 PM

Change 442200 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP-47 language code

https://gerrit.wikimedia.org/r/442200

Jdforrester-WMF mentioned this in T197009: MCS should respect Accept-Language header for MW API requests.Jul 13 2018, 6:00 PM
gerritbot added a comment.Jul 13 2018, 7:28 PM

Change 442200 merged by jenkins-bot:
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP 47 language code

https://gerrit.wikimedia.org/r/442200

Jdforrester-WMF closed this task as Resolved.Jul 14 2018, 1:24 AM
Jdforrester-WMF reassigned this task from Fomafix to cscott.
Jdforrester-WMF subscribed.

The three examples given in the description now all pass on the Beta Cluster (and the only remaining error is the space in the href for "Contact us"):

https://validator.w3.org/nu/?doc=https%3A%2F%2Fen.wikipedia.beta.wmflabs.org%2Fwiki%2FSpecial%3ASpecialPages%3Fuselang%3Dde-formal

https://validator.w3.org/nu/?doc=https%3A%2F%2Fen.wikipedia.beta.wmflabs.org%2Fwiki%2FSpecial%3ASpecialPages%3Fuselang%3Den-rtl

https://validator.w3.org/nu/?doc=https%3A%2F%2Fen.wikipedia.beta.wmflabs.org%2Fwiki%2FSpecial%3ASpecialPages%3Fuselang%3Dnl-informal

Liuxinyu970226 unsubscribed.Jul 14 2018, 3:30 AM
gerritbot added a comment.Jul 14 2018, 9:19 AM

Change 226040 abandoned by Fomafix:
Substitute language codes that are not conform to BCP 47

Reason:
Superseded by I807dd55d49e9bd19443329231326a5b0d3e6c453 with a bijective mapping.

https://gerrit.wikimedia.org/r/226040

Volker_E awarded a token.Jul 16 2018, 9:53 AM
gerritbot added a comment.Sep 12 2018, 3:32 PM

Change 460038 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP 47 language code

https://gerrit.wikimedia.org/r/460038

Fomafix reopened this task as Open.Oct 5 2018, 11:10 AM

Reopen, because https://gerrit.wikimedia.org/r/442200 was reverted and recommitted for review in https://gerrit.wikimedia.org/r/460038.

gerritbot added a comment.Oct 11 2018, 8:46 PM

Change 460038 merged by jenkins-bot:
[mediawiki/core@master] Ensure LanguageCode::bcp47() returns a valid BCP 47 language code

https://gerrit.wikimedia.org/r/460038

Jdforrester-WMF closed this task as Resolved.Oct 11 2018, 9:10 PM
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)); removed Patch-For-Review.
Bawolff subscribed.Mar 26 2023, 1:08 AM

Note: there are reports that this causes problem on ubuntu's version of firefox https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2012430

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits