Page MenuHomePhabricator
Create Task
Maniphest T106521

Creating an external link with no text selected results in a link labelled "null"
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

When adding an external link using the link inspector without any text selection, the result is that a link with the label "null" is created which is unexpected.
A more meaningful label can be done, either by:

  • Using a number between brackets (e.g., "[1]") as VisualEditor does.
  • Using the URL also as the label.

Details

SubjectRepoBranchLines +/-
Fix: Creating an external link with no text selected results link label as "null"mediawiki/extensions/ContentTranslationmaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Jul 22 2015, 2:43 PM
Pginer-WMF raised the priority of this task from to Needs Triage.
Pginer-WMF updated the task description. (Show Details)
Pginer-WMF added projects: Language-Team, ContentTranslation.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2015, 2:43 PM
Arrbee removed a project: Language-Team.Jul 22 2015, 9:49 PM
Arrbee set Security to None.
Amire80 triaged this task as High priority.Jul 23 2015, 5:55 PM
Amire80 added a project: ContentTranslation-Release6.
• santhosh claimed this task.Jul 27 2015, 4:58 AM
• santhosh added a project: LE-CX6-Sprint 1.
• santhosh moved this task from Backlog to In Review on the LE-CX6-Sprint 1 board.
gerritbot subscribed.Jul 27 2015, 4:59 AM

Change 227182 had a related patch set uploaded (by Santhosh):
Fix: Creating an external link with no text selected results link label as "null"

https://gerrit.wikimedia.org/r/227182

gerritbot added a project: Patch-For-Review.Jul 27 2015, 4:59 AM
gerritbot added a comment.Jul 27 2015, 10:16 AM

Change 227182 merged by jenkins-bot:
Fix: Creating an external link with no text selected results link label as "null"

https://gerrit.wikimedia.org/r/227182

• santhosh mentioned this in rMEXT824006aa35e4: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Jul 27 2015, 10:16 AM
Amire80 mentioned this in rECTX449fd91c22f5: Fix: Creating an external link with no text selected results link label as….Jul 27 2015, 10:16 AM
• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 27 2015, 11:00 AM
Amire80 closed this task as Resolved.Jul 27 2015, 2:17 PM
Amire80 moved this task from In Review to Done on the LE-CX6-Sprint 1 board.
Amire80 removed a project: Patch-For-Review.
Amire80 edited a custom field.Jul 27 2015, 4:20 PM
Amire80 moved this task from Backlog to Bugs on the ContentTranslation-Release6 board.Aug 2 2015, 6:37 AM
Amire80 moved this task from Bugs to Links on the ContentTranslation-Release6 board.
Arrbee added a project: OKR-Work.Sep 7 2015, 11:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL