Maniphest T106586

Prefix all global variables
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Jul 22 2015, 7:53 PM

Tags

Referenced Files

None

Subscribers

Description

I would propose

$wgStandardSizes => $wgPageBannerStandardSizes

Basically change $wg prefix to $wgPageBanner

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WikidataPageBanner prefix all globals with WPB	mediawiki/extensions/WikidataPageBanner	master	+22 -22

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdlrobson	T102537 Migrating existing templates to new PageBanner extension
		Resolved		Jdlrobson	T98029 Deploy PageBanner extension on English Wikivoyage project
		Resolved		None	T106587 Convert WikidataPageBanner to extension registration
		Resolved		None	T106586 Prefix all global variables
		Resolved		None	T107001 Invalid property name throws an error

Event Timeline

Jdlrobson created this task.Jul 22 2015, 7:53 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Wikidata-Page-Banner.

Jdlrobson moved this task to June 26-July 18 on the Wikidata-Page-Banner board.

Jdlrobson subscribed.

Restricted Application added a project: Wikidata. · View Herald TranscriptJul 22 2015, 7:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Jdlrobson mentioned this in T98029: Deploy PageBanner extension on English Wikivoyage project.Jul 22 2015, 7:58 PM

Ricordisamoa subscribed.Jul 22 2015, 8:06 PM

Ricordisamoa added a parent task: T98029: Deploy PageBanner extension on English Wikivoyage project.Jul 22 2015, 8:08 PM

Change 226520 had a related patch set uploaded (by Sumit):
WikidataPageBanner prefix all globals with WPB

https://gerrit.wikimedia.org/r/226520

gerritbot added a project: Patch-For-Review.Jul 23 2015, 12:33 PM

Change 226919 had a related patch set uploaded (by Sumit):
WikidataPageBanner prefix all globals with WPB

https://gerrit.wikimedia.org/r/226919

Sumit added a subtask: T107001: Invalid property name throws an error.Jul 27 2015, 7:20 PM

Sumit added a parent task: T106587: Convert WikidataPageBanner to extension registration.

Change 226919 merged by jenkins-bot:
WikidataPageBanner prefix all globals with WPB

https://gerrit.wikimedia.org/r/226919

Sumit closed this task as Resolved.Jul 29 2015, 1:38 AM

Sumit closed subtask T107001: Invalid property name throws an error as Resolved.

Sumit removed a project: Wikidata.

Sumit set Security to None.

Sumit mentioned this in rEWDP208dc22c1242: WikidataPageBanner prefix all globals with WPB.Jul 30 2015, 10:12 PM

Diffusion mentioned this in rMEXTb005a4c37b0a: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Jul 30 2015, 10:16 PM