Page MenuHomePhabricator

test_SearchOverlay.js should not use mw.loader.using or M.on
Closed, ResolvedPublic

Description

This unit test needs to be rewritten:

http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/2e992fd1c8e4a22c57f3913fb67f6bce42d6f582/tests%2Fqunit%2Fmobile.search%2Ftest_SearchOverlay.js

  • It is unnecessarily async. It loads mobile.search.beta despite stubbing it. SearchApi should be fine for this.
  • Stubbing should happen in teardown/tear up
  • It causes failures in plain mode
  • Don't rely on M.on - it just confuses what is being tested

Event Timeline

Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: Readers-Web-Backlog.
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.

Change 226942 had a related patch set uploaded (by Jdlrobson):
Rewrite wikidata description search test

https://gerrit.wikimedia.org/r/226942

@Krinkle once this patch is merged (and all it's dependencies) then T103027 should be mergeable yay :)

Change 226942 merged by jenkins-bot:
Rewrite wikidata description search test

https://gerrit.wikimedia.org/r/226942

Jdlrobson closed this task as Resolved.Jul 27 2015, 11:13 PM