Maniphest T106622

test_SearchOverlay.js should not use mw.loader.using or M.on
Closed, ResolvedPublic
Actions

Description

This unit test needs to be rewritten:

http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/2e992fd1c8e4a22c57f3913fb67f6bce42d6f582/tests%2Fqunit%2Fmobile.search%2Ftest_SearchOverlay.js

It is unnecessarily async. It loads mobile.search.beta despite stubbing it. SearchApi should be fine for this.
Stubbing should happen in teardown/tear up
It causes failures in plain mode
Don't rely on M.on - it just confuses what is being tested

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/MobileFrontend	master	+81 -94	Rewrite wikidata description search test

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T103027 QUnit should bypass target mode
		Resolved		Jdlrobson	T104362 Certain tests failing in bypassed target mode
		Resolved		Jdlrobson	T106622 test_SearchOverlay.js should not use mw.loader.using or M.on

Event Timeline

Jdlrobson created this task.Jul 22 2015, 10:15 PM

Jdlrobson raised the priority of this task from to Low.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Readers-Web-Backlog.

Jdlrobson updated the task description. (Show Details)

Jdlrobson set Security to None.

Jdlrobson added subscribers: Jdlrobson, Aklapper, gerritbot, Krinkle.

Jdlrobson moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.Jul 23 2015, 5:10 PM

Jdlrobson claimed this task.Jul 24 2015, 11:23 PM

Change 226942 had a related patch set uploaded (by Jdlrobson):
Rewrite wikidata description search test

https://gerrit.wikimedia.org/r/226942

gerritbot added a project: Patch-For-Review.Jul 24 2015, 11:48 PM

@Krinkle once this patch is merged (and all it's dependencies) then T103027 should be mergeable yay :)

Jdlrobson mentioned this in T106628: InfiniteScroll and api qunit tests are being skipped..Jul 24 2015, 11:50 PM

Change 226942 merged by jenkins-bot:
Rewrite wikidata description search test

https://gerrit.wikimedia.org/r/226942

• Konfused-Kitten mentioned this in rEMFR0cb50788f5ef: Rewrite wikidata description search test.Jul 27 2015, 10:03 PM

Diffusion mentioned this in rMEXTa0b487d8ba75: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Jul 27 2015, 10:03 PM

Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 27 2015, 11:00 PM

Jdlrobson closed this task as Resolved.Jul 27 2015, 11:13 PM

• Phabricator_maintenance moved this task from Triaged but Future to 2015-16 Q1 on the Readers-Web-Backlog board.Mar 7 2018, 1:11 AM