Page MenuHomePhabricator
Create Task
Maniphest T106631

Define a renaming schema for string constants
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Use extension.json, empty PHP entry pointmediawiki/extensions/Mathmaster+500 -429
Convert the math integer constants to string constantsmediawiki/extensions/Mathmaster+148 -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolvedWhyameriT106630 Migrate string constants
ResolvedPhysikerweltT106631 Define a renaming schema for string constants
· · ·

Event Timeline

Physikerwelt created this task.Jul 22 2015, 11:53 PM
Physikerwelt claimed this task.
Physikerwelt raised the priority of this task from to Medium.
Physikerwelt updated the task description. (Show Details)
Physikerwelt added projects: Math, Patch-For-Review.
Physikerwelt added subscribers: Aklapper, Legoktm, gerritbot and 4 others.
gerritbot added a comment.Jul 22 2015, 11:54 PM

Change 226436 had a related patch set uploaded (by Physikerwelt):
Convert the math integer constants to string constants

https://gerrit.wikimedia.org/r/226436

Physikerwelt added a comment.Jul 22 2015, 11:55 PM

See
https://gerrit.wikimedia.org/r/#/c/226436/3/tests/MathUtilsTest.php
for a full mapping of the old and new constants

Physikerwelt moved this task from Inbox to Doing on the Math board.Jul 23 2015, 3:38 PM
gerritbot added a comment.Jul 27 2015, 10:49 PM

Change 187654 had a related patch set uploaded (by Physikerwelt):
Convert the math integer constants to string constants

https://gerrit.wikimedia.org/r/187654

gerritbot added a comment.Jul 27 2015, 10:54 PM

Change 226436 abandoned by Physikerwelt:
Convert the math integer constants to string constants

Reason:
Reviwing 3 times seems to be too much work
merged everything to
I6d1094ece79e912d9ddbef6681a25196c7a6e801

https://gerrit.wikimedia.org/r/226436

Jdforrester-WMF closed this task as Resolved.Jul 30 2015, 10:02 PM
Jdforrester-WMF subscribed.
gerritbot added a comment.Jul 30 2015, 10:03 PM

Change 187654 merged by jenkins-bot:
Use extension.json, empty PHP entry point

https://gerrit.wikimedia.org/r/187654

Legoktm mentioned this in rEMATbc52c77d242a: Use extension.json, empty PHP entry point.Jul 30 2015, 10:14 PM
Physikerwelt mentioned this in rMEXT66eff533b4a6: Updated mediawiki/extensions Project: mediawiki/extensions/Math….Jul 30 2015, 10:16 PM
Liuxinyu970226 unsubscribed.Jul 31 2015, 9:16 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL