Page MenuHomePhabricator

Drop use of OOUI\Theme::setSingleton()
Closed, ResolvedPublic

Description

To quote Bartosz
"Indeed, calling OOUI\Theme::setSingleton() is entirely unnecessary if you also call OutputPage::enableOOUI() (which you usually should when using server-side OOUI widgets, and which this extension correctly does), as the latter calls the former. I reviewed https://gerrit.wikimedia.org/r/#/c/215029/ which added the OutputPage::enableOOUI() call, I did not review or see https://gerrit.wikimedia.org/r/#/c/221459/ which needlessly added the OOUI\Theme::setSingleton() call. If something does actually break if you remove it, please file a bug and assign to me, and I'll debug it."

Details

Related Gerrit Patches:
mediawiki/extensions/WikidataPageBanner : masterWikidataPageBanner drop OOUI\Theme::setSingleton

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: matmarex, ssastry, Legoktm and 8 others.
Restricted Application added a project: Wikidata. · View Herald TranscriptJul 23 2015, 4:32 PM

Change 226558 had a related patch set uploaded (by Sumit):
WikidataPageBanner drop OOUI\Theme::setSingleton

https://gerrit.wikimedia.org/r/226558

matmarex closed this task as Resolved.Jul 24 2015, 11:04 AM
matmarex assigned this task to Sumit.
matmarex triaged this task as Medium priority.
matmarex removed a project: Patch-For-Review.
matmarex set Security to None.

Change 226558 merged by jenkins-bot:
WikidataPageBanner drop OOUI\Theme::setSingleton

https://gerrit.wikimedia.org/r/226558