To quote Bartosz
"Indeed, calling OOUI\Theme::setSingleton() is entirely unnecessary if you also call OutputPage::enableOOUI() (which you usually should when using server-side OOUI widgets, and which this extension correctly does), as the latter calls the former. I reviewed https://gerrit.wikimedia.org/r/#/c/215029/ which added the OutputPage::enableOOUI() call, I did not review or see https://gerrit.wikimedia.org/r/#/c/221459/ which needlessly added the OOUI\Theme::setSingleton() call. If something does actually break if you remove it, please file a bug and assign to me, and I'll debug it."
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| WikidataPageBanner drop OOUI\Theme::setSingleton | Sumit | mediawiki/extensions/WikidataPageBanner | master | +0 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T102537 Migrating existing templates to new PageBanner extension | |||
| Resolved | Jdlrobson | T98029 Deploy PageBanner extension on English Wikivoyage project | |||
| Resolved | Sumit | T106706 Drop use of OOUI\Theme::setSingleton() |
Event Timeline
Comment Actions
Change 226558 had a related patch set uploaded (by Sumit):
WikidataPageBanner drop OOUI\Theme::setSingleton
Comment Actions
Change 226558 merged by jenkins-bot:
WikidataPageBanner drop OOUI\Theme::setSingleton