Page MenuHomePhabricator

Badly formatted reference in template is not escaped by VE, resulting in completely damaged article
Closed, DeclinedPublic

Description

Hi, in this edit, VE let a user add an incorrectly formatted reference in a template (<ref>...<ref>) without escaping anything, making the article completely damaged. On a following edit, VE made even more damages by adding nowiki tags all over the place.

Event Timeline

NicoV raised the priority of this task from to Needs Triage.
NicoV updated the task description. (Show Details)
NicoV subscribed.

I can't reproduce this: https://en.wikipedia.org/w/index.php?diff=673351534&oldid=671886705

However, when I pasted in the ref, it did not add a wikitext warning. It behaves differently if you type it in rather than pasting.

Broken template is broken? What's the action requested here?

@Jdforrester-WMF

Well, it's simple : before VE edit the article was fine, then a user tried to add a reference inside a template parameter using VE and incorrectly formatted it (2 opening ref tags instead of a pair), and instead of escaping the badly formatted parameter, the result saved with VE is a completely trashed article.

What' requested: prevent VE to completely trash an article when someone simply edits a parameter inside a template call... For once, VE should have put nowiki tags around the incorrect ref tags instead of trashing the article. And I doubt that the user saw in VE preview that he had completely trashed the article

I had checked adding the citation in regular article text, and it was obvious that it didn't look normal. I just checked as a template parameter in that infobox/that article, and when you mistype the ref tags inside a parameter, then the display completely changes. The infobox becomes a full-width mess of monospace wikitext. It was very obvious that something was wrong.

Jdforrester-WMF claimed this task.

No actionables.