With T46443 we have python tox installed using the puppet 'pip' provider:
package { 'tox': ensure => present, provider => 'pip', require => Package['python-pip'], }
I guess that installs whatever latest version is available in pipy, so we want to pin it to a specific version. Looking at puppet code, it seems we can pass the version to the ensure parameters.
Currently all slaves have 1.9.2.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| contint: pin tox to version 1.9.2 | operations/puppet | production | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T114360 Remove packages pep8 / pylint and pyflakes from CI slaves | |||
| Resolved | hashar | T55354 JJB: replace pyflakes / pep8 jobs with tox-jessie job | |||
| Declined | hashar | T55353 migrate all .pep8 files content to setup.cfg / tox.ini | |||
| Resolved | None | T46443 Jenkins: install tox on Precise labs instances | |||
| Resolved | hashar | T106799 Pin tox to a specific version |
Change 226694 had a related patch set uploaded (by Hashar):
contint: pin tox to version 1.9.2
I used integration-slave-trusty-1011 as a playground area. I uninstalled pip and ran puppet:
Debug: Executing '/usr/bin/pip install -q tox' Notice: /Stage[main]/Contint::Packages::Labs/Package[tox]/ensure: created
tox --version 2.1.1 imported from /usr/local/lib/python2.7/dist-packages/tox/__init__.pyc
With Gerrit patch contint: pin tox to version 1.9.2 https://gerrit.wikimedia.org/r/#/c/226694/ which uses ensure => '1.9.2' :
Debug: Executing '/usr/bin/pip install -q tox==1.9.2' Notice: /Stage[main]/Contint::Packages::Labs/Package[tox]/ensure: created
tox --version 1.9.2 imported from /usr/local/lib/python2.7/dist-packages/tox/__init__.pyc
Deployed https://gerrit.wikimedia.org/r/#/c/226694/ on the integration puppetmaster and that works.
Now pending for ops to review and merge the change.