Page MenuHomePhabricator
Create Task
Maniphest T106819

Regression: Link context not showing images
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The link cache is getting populated with {missing:false}/{missing:true} micro entries, so when we get full data from the API including image and description, we don't override the link cache.

Details

SubjectRepoBranchLines +/-
Separate 'isMissing' micro cache from full link data cachemediawiki/extensions/VisualEditormaster+30 -10
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Jul 24 2015, 3:17 PM
Esanders claimed this task.
Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added projects: VisualEditor, VisualEditor-MediaWiki.
Esanders subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2015, 3:17 PM
gerritbot subscribed.Jul 24 2015, 3:18 PM

Change 226727 had a related patch set uploaded (by Esanders):
Separate 'isMissing' micro cache from full link data cache

https://gerrit.wikimedia.org/r/226727

gerritbot added a project: Patch-For-Review.Jul 24 2015, 3:18 PM
gerritbot added a comment.Jul 24 2015, 6:43 PM

Change 226727 merged by jenkins-bot:
Separate 'isMissing' micro cache from full link data cache

https://gerrit.wikimedia.org/r/226727

Esanders mentioned this in rEVED8250c8ad5444: Separate 'isMissing' micro cache from full link data cache.Jul 24 2015, 6:44 PM
Jdforrester-WMF closed this task as Resolved.Jul 24 2015, 6:45 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki-Links; removed Patch-For-Review.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
• Forrestbot added a project: WMF-deploy-2015-07-28_(1.26wmf16).Jul 24 2015, 7:00 PM
Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Jul 24 2015, 7:16 PM
Ryasmeen added a project: Verified-in-Phase0.Jul 29 2015, 4:32 AM
Ryasmeen added a project: Verified-in-Phase2.Jul 30 2015, 11:18 PM
Jdforrester-WMF moved this task from TR1: Releases to TR0: Interrupt on the VisualEditor board.Aug 26 2015, 1:41 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL