Page MenuHomePhabricator

Make sure the DM handles content without permissions
Open, MediumPublic

Description

Look at those two cases:

http://en.wikipedia.beta.wmflabs.org/wiki/Topic:Sl18xph3p9den4ob (deleted topic)
mw.flow.data.blocks.topic has no 'roots'.

http://en.wikipedia.beta.wmflabs.org/wiki/Topic:Sl18xaj7bextx9g8 (non deleted topic)
mw.flow.data.blocks.topic has 'roots'

The first one returned without permission to view; as a result, the topic is not rendered (and the DM should follow suit.)

This is probably true to more than just this case. Right now, the DM skips boards if .roots is undefined (which is the case above) but that is probably a bad thing to count on. We should have a proper way of validating whether the content we are on is viewable at all before we even attempt to send it to the data model and render it.

Event Timeline

Mooeypoo raised the priority of this task from to Needs Triage.
Mooeypoo updated the task description. (Show Details)
Mooeypoo added a subscriber: Mooeypoo.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mooeypoo renamed this task from Single-topic view response structure from the API differs between active and deleted topic to Make sure the DM handles content without permissions.Jul 24 2015, 7:52 PM
Mooeypoo updated the task description. (Show Details)
Mooeypoo set Security to None.
DannyH triaged this task as Medium priority.Jul 27 2015, 6:57 PM
DannyH moved this task from Untriaged to Team discussion on the Collaboration-Team-Triage board.
DannyH added a subscriber: DannyH.