Page MenuHomePhabricator
Create Task
Maniphest T106908

ve.{ui,ce}.Surface#{enable,disable} should implement OO.ui.Widget#setDisabled
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

A ve.ui.Surface is an OOUI widget, but it doesn't override setDisabled correctly. Instead, you have to call disable and enable on it.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
[DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabledVisualEditor/VisualEditormaster+35 -18
Customize query in gerrit

Event Timeline

Catrope created this task.Jul 24 2015, 11:00 PM
Catrope raised the priority of this task from to Needs Triage.
Catrope updated the task description. (Show Details)
Catrope added a project: VisualEditor.
Catrope subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2015, 11:00 PM
Jdforrester-WMF triaged this task as Low priority.Jul 24 2015, 11:14 PM
Jdforrester-WMF added a project: Technical-Debt.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Jul 28 2015, 7:10 PM
Esanders subscribed.Dec 15 2015, 3:30 PM

ve.ui.Surface is an OOUI element, not a widget.

gerritbot subscribed.Dec 15 2015, 4:17 PM

Change 259274 had a related patch set uploaded (by Esanders):
[DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled

https://gerrit.wikimedia.org/r/259274

gerritbot added a project: Patch-For-Review.Dec 15 2015, 4:17 PM
Jdforrester-WMF closed this task as Resolved.Dec 15 2015, 5:15 PM
Jdforrester-WMF assigned this task to Esanders.
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF added a project: MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)).
gerritbot added a comment.Dec 15 2015, 5:21 PM

Change 259274 merged by jenkins-bot:
[DEPRECATING CHANGE] ve.ui.Surface: Make an OO.ui.Widget and implement #setDisabled

https://gerrit.wikimedia.org/r/259274

Jdforrester-WMF moved this task from Freezer to TR0: Interrupt on the VisualEditor board.Jan 19 2016, 1:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits