Page MenuHomePhabricator

commonscat ignoreTemplates with tuples only checks first parameter
Closed, ResolvedPublic

Description

commonscat has a dict ignoreTemplates with some entries as tuples like:

ignoreTemplates = {
...
    'eo': [u'Commons',
           (u'Projekto/box', 'commons='),
           (u'Projekto', 'commons='),
           (u'Projektoj', 'commons='),
           (u'Projektoj', 'commonscat=')],
...

The method skipPage is supposed to ignore the page if the template exists with the mentioned parameter name.
However the logic only compares the first parameter of the template in the page against that the mentioned parameter name.
The commonscat logic for this dates back to 2008 (901e48d39).

Details

Related Changes in Gerrit:

Event Timeline

jayvdb claimed this task.
jayvdb raised the priority of this task from to Low.
jayvdb updated the task description. (Show Details)
jayvdb added a project: Pywikibot.
jayvdb subscribed.

Change 226984 had a related patch set uploaded (by John Vandenberg):
Fix skip page template parameter check

https://gerrit.wikimedia.org/r/226984

Dvorapa subscribed.

Please undo if still working on it

Xqt assigned this task to jayvdb.

Change 226984 merged by jenkins-bot:

[pywikibot/core@master] Fix skip page template parameter check

https://gerrit.wikimedia.org/r/226984