Page MenuHomePhabricator

Icons are missing on fast closing and opening the tabs
Closed, ResolvedPublic

Description

Steps to reproduce:

  • A edit window is loaded and the Advanced tab is open.
  • Click fast twice on the Advanced tab.
  • The tab correctly closes and open again, but the icons are missing.

Event Timeline

Fomafix raised the priority of this task from to Low.
Fomafix updated the task description. (Show Details)
Fomafix added a project: WikiEditor.
Fomafix added a subscriber: Fomafix.

Confirmed.-- Win8.1 & IE11

Was able to reproduce several times.

  • Leaving the Advanced tab open in the previous editing session had no bearing on the behavior.
  • Only the "speed" of opening & closing the tab causes the icons not to render.

And sometimes it took 2 tries +; otherwise happens after 1 try.

https://gerrit.wikimedia.org/r/226676 changes the behavior but does not solve the problem.

Can we rule out the possibility this behavior was always present yet not revealed until now?

I mean is it possible this might be more about the use of a single sprited multi-image file for all the buttons or something than it is about deferred loading and spinner delay?

The reason for the strange behavior are unfinished animations. https://gerrit.wikimedia.org/r/226676 combines the animation of the height and the fading of the icons to one animation and removes the strange setTimeout(). I guess the problems with animations can solved by aborting any running animations before starting new animations.

Change 280685 had a related patch set uploaded (by Ferveo):
Stop any other tab animations when clicking on the tab button

https://gerrit.wikimedia.org/r/280685

Change 280685 merged by jenkins-bot:
Stop any other tab animations when clicking on the tab button

https://gerrit.wikimedia.org/r/280685

TheDJ assigned this task to ferveo.