When I use an invalid property name such as $wgBannerProperty="", WikidataPageBanner throws an error as https://phabricator.wikimedia.org/P1067
Expected behaviour should be to add no wikidata banner on the article.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| WikidataPageBanner check for invalid Property name | mediawiki/extensions/WikidataPageBanner | master | +4 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T102537 Migrating existing templates to new PageBanner extension | |||
| Resolved | Jdlrobson | T98029 Deploy PageBanner extension on English Wikivoyage project | |||
| Resolved | None | T106587 Convert WikidataPageBanner to extension registration | |||
| Resolved | None | T106586 Prefix all global variables | |||
| Resolved | None | T107001 Invalid property name throws an error |
Event Timeline
Comment Actions
Change 227176 had a related patch set uploaded (by Sumit):
WikidataPageBanner check for invalid Property name
Comment Actions
Oh I see... so this was an existing bug.
(The reason this is problematic is the first experience a user who has newly installed this extension has is it exploding in their face!) Thanks for clarifying it's an existing bug.
Comment Actions
Change 227176 merged by jenkins-bot:
WikidataPageBanner check for invalid Property name