Page MenuHomePhabricator
Create Task
Maniphest T107082

Creating a user with username=Rrrr produces a warning that displays html entities/code
Closed, InvalidPublic
Actions

Description

Found when testing 4.1.6.170 alpha and 4.1.6.168 beta on iPad mini iOS 8.2
2.0.105-alpha-2015-07-27 on Samsung Tablet Ce0168(Android 4.0.4)

  1. On the 'Create account' page, type 'rrrr' (no quotes) as User name
  2. Fill in password and confirm password fields, click on Next.
  3. Enter captcha - click Done and the warning will be displayed:
The name &quot;Rrrr&quot; is too similar to the following username:<ul><li>Rrrr\\\\\\\\\\<\li><\ul>Please choose another name.

IMG_0249 (1).PNG (2×1 px, 205 KB)

IMG_0248.PNG (2×1 px, 199 KB)

Expected:

  • a user should not see any irrelevant info - e.g. specific references to other usernames or some html code.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Improve duration/presentation of error Snackbars.apps/android/wikipediamaster+32 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Jul 27 2015, 8:43 PM
Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added projects: Wikipedia-Android-App-Backlog, Wikipedia-iOS-App-Backlog.
Etonkovidova subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2015, 8:43 PM
Dbrant subscribed.Jul 27 2015, 8:58 PM

a user should not see any irrelevant info - e.g. specific references to other usernames or some html code.

Well I would argue that the reference to another username is very relevant in this case, and should be preserved. It's just the HTML markup that is the issue. It's a bit unfortunate that the extension that returns this error puts the conflicting username(s) inside a <ul> list, since this will make it much harder for us to parse and present natively.

• BGerstle-WMF subscribed.Jul 30 2015, 2:02 PM

Not to mention ampersand escapes:

&quot; Rrrr &quot;

Krenair subscribed.Jul 30 2015, 2:45 PM

Sounds like an error message from the AntiSpoof extension

gerritbot subscribed.Aug 10 2015, 1:44 PM

Change 230538 had a related patch set uploaded (by Dbrant):
Improve duration/presentation of error Snackbars.

https://gerrit.wikimedia.org/r/230538

gerritbot added a project: Patch-For-Review.Aug 10 2015, 1:44 PM
gerritbot added a comment.Aug 10 2015, 7:42 PM

Change 230538 merged by jenkins-bot:
Improve duration/presentation of error Snackbars.

https://gerrit.wikimedia.org/r/230538

Dbrant mentioned this in rAPAW12cafcbd8071: Improve duration/presentation of error Snackbars..Aug 10 2015, 7:44 PM
Dbrant added a subtask: T74387: "createaccount" action failure should return the name of the extension that caused it to fail..Aug 11 2015, 6:14 PM
Dbrant moved this task from Needs Triage to Tracking on the Wikipedia-Android-App-Backlog board.Aug 11 2015, 6:16 PM
MBinder_WMF added a project: Essential-Work.Sep 9 2015, 7:32 PM
MBinder_WMF removed a project: Essential-Work.Sep 9 2015, 7:43 PM
• JMinor triaged this task as Lowest priority.Jan 25 2016, 10:56 PM
• JMinor set Security to None.
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
MBinder_WMF added a project: iOS-app-Bugs.Jul 25 2016, 7:15 PM
• JMinor closed this task as Invalid.Aug 24 2016, 6:42 PM
matmarex closed subtask T74387: "createaccount" action failure should return the name of the extension that caused it to fail. as Resolved.Jun 26 2024, 1:43 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 26 2024, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits