[4.1.7.168] Regression: lead images not positioned correctly
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jul 27 2015, 11:39 PM

Description

Steps to reproduce

Clean install
Go to Barack Obama

Expected results

Actual results

'Nellie Kim' (lead image; the thumbnail for Saved/Recent is correct)

Dev notes

The property where focal rects were stored was initialized to an empty array, meaning that we always thought face detection previously ran, even when it didn't. Property is no initialized to nil as expected, and tests were added to ensure proper behavior in the following cases:

New image w/o any data on disk (detection hasn't run, no faces)
Image w/ data on disk w/o a focalRects field (detection hasn't run, no faces—same as above)
Image w/ data on disk with focalRects field set to empty array (detection has run, no faces)
Image w/ data on disk w/ focalRects field set to non-empty array (detection has run, hasFaces is true)

Event Timeline

Etonkovidova created this task.Jul 27 2015, 11:39 PM

Etonkovidova raised the priority of this task from to Needs Triage.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added a project: Wikipedia-iOS-App-Backlog.

Etonkovidova subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2015, 11:39 PM

• BGerstle-WMF renamed this task from [4.1.7.170 alpha] Regression: lead images not positioned correctly to [4.1.7.168] Regression: lead images not positioned correctly.Jul 29 2015, 9:59 PM

• BGerstle-WMF claimed this task.

• BGerstle-WMF edited projects, added Wikipedia-iOS-App-Development; removed Wikipedia-iOS-App-Backlog.

• BGerstle-WMF set Security to None.

• BGerstle-WMF moved this task from Tasks from Product Backlog to Needs Code Review on the Wikipedia-iOS-App-Development board.

• BGerstle-WMF updated the task description. (Show Details)

• BGerstle-WMF updated the task description. (Show Details)Jul 29 2015, 10:02 PM

• BGerstle-WMF moved this task from Needs Code Review to Needs QA on the Wikipedia-iOS-App-Development board.Jul 30 2015, 5:20 PM

Checked on 4.1.7.171 beta(release candidate) on iPad mini iOS 8.2 - 'Barack Obama' display is correct.
'Nellie Kim'(and also 'Viceregal consort of Canada') lead img are still displayed incorrectly, but it's not a regression. Closing the issue.

Etonkovidova closed this task as Resolved.Jul 30 2015, 7:55 PM