Maniphest T107122

VisualEditor tests fail in target agnostic mode
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 28 2015, 12:46 AM

Tags

Referenced Files

None

Subscribers

Description

The patch from @Krinkle https://gerrit.wikimedia.org/r/#/c/216886/ forces all tests to run regardless of whether they are target desktop or mobile. This patch is ready to be merged but several tests fail [1] preventing it from doing so. All of which live in VisualEditor.

I suspect they are written to expect the Minerva/Vector interface and might need a few additional steps added to module setup so assertions can be met.

ve.dm.MWImageModel Create and manipulate image nodes
ve.ce.Surface (MW) handleLinearDelete
ve.ce.ContentBranchNode (MW) getRenderedContents
ve.ui.FormatAction (MW) convert (MW-specific types)
ve.init.mw.ViewPageTarget compatibility

[1] https://integration.wikimedia.org/ci/job/mediawiki-extensions-qunit/5377/console

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Make scrollIntoView a VE utility function	VisualEditor/VisualEditor	master	+12 -3
	Abort scroll animations on teardown	mediawiki/extensions/VisualEditor	master	+2 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krinkle	T103027 QUnit should bypass target mode
		Resolved		Jdlrobson	T104362 Certain tests failing in bypassed target mode
		Resolved		Jdlrobson	T107122 VisualEditor tests fail in target agnostic mode

Event Timeline

Jdlrobson created this task.Jul 28 2015, 12:46 AM

Jdlrobson claimed this task.

Jdlrobson raised the priority of this task from to Low.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added projects: VisualEditor, Contributors-Team, Blocked-on-Editing.

Jdlrobson added subscribers: • bmansurov, Jdlrobson, Aklapper and 2 others.

They seem to be failing due to Error: Unfinished animations: 1

Change 227745 had a related patch set uploaded (by Esanders):
Disable scroll animation when running tests

https://gerrit.wikimedia.org/r/227745

gerritbot added a project: Patch-For-Review.Jul 29 2015, 4:40 PM

Change 227751 had a related patch set uploaded (by Esanders):
Make scrollIntoView a VE utility function

https://gerrit.wikimedia.org/r/227751

Change 227745 abandoned by Esanders:
Abort scroll animations on teardown

Reason:
Cleaner fix in core Id9b460

https://gerrit.wikimedia.org/r/227745

Change 227751 merged by jenkins-bot:
Make scrollIntoView a VE utility function

https://gerrit.wikimedia.org/r/227751

Thanks for the speediness. Looks like there is one remaining problem:
ve.dm.** several FAILED: Unfinished AJAX request.

Esanders mentioned this in rGVED7692890107bb: Make scrollIntoView a VE utility function.Jul 30 2015, 10:13 PM

Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.Aug 4 2015, 7:18 PM

Jdlrobson closed this task as Resolved.Aug 6 2015, 8:16 PM

Jdforrester-WMF set Security to None.Aug 6 2015, 8:17 PM

Jdforrester-WMF edited a custom field.

Jdforrester-WMF removed a project: Patch-For-Review.Sep 1 2015, 10:53 PM

Jdforrester-WMF added a project: WMF-deploy-2015-08-04_(1.26wmf17).Sep 10 2015, 7:13 PM