Blueprint currently uses semantically non-correct to its contents <nav class="navbar navbar-fixed-top"> for elements that are semantically better represented by <header role="banner"> element. Same goes for <div class="container" id="content">, which should be replaced by <main class="container" id="content" role="main">.
Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Use HTML5 sectioning elements and ARIA roles | mediawiki/skins/Blueprint | master | +355 -18 |
Event Timeline
Change 227582 had a related patch set uploaded (by Prtksxna):
Make use of HTML5 sectioning elements
As MediaWiki 1.26 is currently integrating jQuery 1.11.3 it's not yet providing support for `<main>´ element in IE<9.
Therefore we need to include html5shiv-printshiv.js as well. Why html5shiv-printshiv and not just html5shiv? Blueprint is us for the Living Style Guide, there is a probabiliy for people printing pages.
Change 227582 abandoned by VolkerE:
Make use of HTML5 sectioning elements
Reason:
abandoning this, starting with new patch
Change 227582 restored by VolkerE:
Make use of HTML5 sectioning elements
Reason:
reverting wrong decision beforehand
@Prtksxna (Commenting here again, aside from T88023) Latest patch set #4 includes role="navigation" and footer[role="contentinfo"].
I've also altered markup order, so that <header> comes before <nav> for better screen-reader/keyboard user experience and added a skip-to-nav link.
A question still open is translation of skip link. Is [[ https://www.mediawiki.org/wiki/Manual:Messages_API#Language | wfMessage() ]] the right approach?
@Prtksxna I'd prefer to go for another task caring about i18n and just merge that with changes included so far.
As a comment by @Pastakhov went about necessity of including ARIA landmark role attributes, instead of relying to native semantic roles:
As long as not all browsers (ex: Fx<21, Ch<26) map the ARIA landmark roles to the elements, it's recommended to include the role attributes. See f.e. on `role="main" over at http://html5doctor.com/the-main-element/#comment-35495