Page MenuHomePhabricator

[Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required
Closed, ResolvedPublic1 Story Points

Description

Regression in UX in the new shortcut added in T69868.

On wikis where edit summary is required or on any wiki where a user has forceeditsummary preference enabled ("Prompt me when entering a blank edit summary") the new "Save page" button doesn't work properly,

When the button is clicked the first time, nothing happens.

What really happens is that on the now-invisible panel for the edit summary a "Reminder:" is added, but this is not visible to the user. I imagine other error or warning scenarios (captcha, blacklist, abusefilter, etc.) may also cause issues here where the user is stranded.

Event Timeline

Krinkle created this task.Jul 29 2015, 5:30 AM
Krinkle updated the task description. (Show Details)
Krinkle raised the priority of this task from to Unbreak Now!.
Krinkle added a subscriber: Krinkle.
Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 29 2015, 5:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle renamed this task from "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required to [Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required.Jul 29 2015, 5:32 AM
Krinkle removed a project: VisualEditor-MediaWiki.
Krinkle set Security to None.

Change 227747 had a related patch set uploaded (by Alex Monk):
When saving from review screen, swap to main save screen

https://gerrit.wikimedia.org/r/227747

Krenair claimed this task.Jul 29 2015, 4:49 PM

Change 227747 merged by jenkins-bot:
When saving from review screen, swap to main save screen

https://gerrit.wikimedia.org/r/227747

Jdforrester-WMF closed this task as Resolved.Jul 30 2015, 9:56 PM
Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.
Jdforrester-WMF edited a custom field.