[Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Krinkle
	Jul 29 2015, 5:30 AM

Description

Regression in UX in the new shortcut added in T69868.

On wikis where edit summary is required or on any wiki where a user has forceeditsummary preference enabled ("Prompt me when entering a blank edit summary") the new "Save page" button doesn't work properly,

When the button is clicked the first time, nothing happens.

What really happens is that on the now-invisible panel for the edit summary a "Reminder:" is added, but this is not visible to the user. I imagine other error or warning scenarios (captcha, blacklist, abusefilter, etc.) may also cause issues here where the user is stranded.

Details

	Subject	Repo	Branch	Lines +/-
	When saving from review screen, swap to main save screen	mediawiki/extensions/VisualEditor	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rEVED7b7219fcb6c7: When saving from review screen, swap to main save screen
Mentioned Here: T69868: "Review your changes" dialog should have a save button

Event Timeline

Krinkle created this task.Jul 29 2015, 5:30 AM

Krinkle raised the priority of this task from to Unbreak Now!.

Krinkle updated the task description. (Show Details)

Krinkle added projects: VisualEditor-MediaWiki, Regression.

Krinkle subscribed.

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 29 2015, 5:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Krinkle renamed this task from "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required to [Regression 1.26wmf16] "Save page" in "Review your changes" panel doesn't work correctly when edit summary is required.Jul 29 2015, 5:32 AM

Krinkle removed a project: VisualEditor-MediaWiki.

Krinkle set Security to None.

Krinkle added a project: VisualEditor-MediaWiki.

Change 227747 had a related patch set uploaded (by Alex Monk):
When saving from review screen, swap to main save screen

https://gerrit.wikimedia.org/r/227747

gerritbot added a project: Patch-For-Review.Jul 29 2015, 4:48 PM

Krenair claimed this task.Jul 29 2015, 4:49 PM

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.Jul 30 2015, 5:32 PM

Change 227747 merged by jenkins-bot:
When saving from review screen, swap to main save screen

https://gerrit.wikimedia.org/r/227747

• Forrestbot added a project: WMF-deploy-2015-08-04_(1.26wmf17).Jul 30 2015, 8:00 PM

Jdforrester-WMF closed this task as Resolved.Jul 30 2015, 9:56 PM