| • Niedzielski | |
| Jul 29 2015, 3:47 PM |
| F23065868: Screenshot_20180628-190702.png | |
| Jun 29 2018, 2:08 AM |
| F16758607: tempFileForShare_20180406-180338.jpg | |
| Apr 6 2018, 5:11 PM |
"Share link" in the menu is disabled on file pages - it does not bring up the sharing dialog when you tap on it - but the menu item appears nevertheless.
Steps:
Go to the MACS J1149 Lensed Star 1 article
Tap on the lead image
Go to the file page for the image
Hit the menu in the upper right
Expected:
Standard "Share sheet" to share link to the file page appears.
Actual:
"Share link" appears in the menu, but when a user taps on it no sharing dialog appears.
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Fix: Share link menu item is not working on File pages | Cooltey | apps/android/wikipedia | master | +2 -2 |
It's worth considering whether we want to even support sharing facts from file pages, considering that we expect almost no users to ever get to a file page. It might be worth simply disabling share a fact and defaulting to normal sharing on file pages to avoid this issue entirely.
@LGoto: Which Android App related project should this task be in? Please associate this task to an active 'code project' if possible. Thanks!
Updated task description to clarify it is about the Share link option in the File page overflow, not about Share-a-fact (also similar to T106610 , let's just leave the Share-a-fact on file pages as is)
Change 439787 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Share link menu item is not working on File pages
Change 439787 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Share link menu item is not working on File pages
Hi @ABorbaWMF
Yes, the "Share Link" is expected to see on a File page.
The ticket was talking about the expected behavior that a "share sheet" dialog should be seen when tapping on the "Share Link".
