Page MenuHomePhabricator
Create Task
Maniphest T107343

OO.ui.BookletLayout.prototype.focusFirstFocusable doesn't find focusable elements very well
Closed, ResolvedPublic
Actions

Description

OO.ui.BookletLayout.prototype.focusFirstFocusable doesn't find focusable elements very well. For example, it misses our own ButtonWidgets. It should at least add '[tabindex]' to 'input, select, textarea, button, object' when finding elements to check. There is some interesting related discussion at T69156#1022986 onward. (Spotted by Anomie at https://gerrit.wikimedia.org/r/#/c/224966/5/src/widgets/CapsuleWidget.js,cm.)

(By the way, the method is duplicated as OO.ui.IndexLayout.prototype.focusFirstFocusable, we should put it somewhere else. We have OO.ui.isFocusableElement in core.js, that looks like a good place.)

Details

SubjectRepoBranchLines +/-
BookletLayout, IndexLayout: Make autoFocus and focussing more reliableoojs/uimaster+52 -70
Customize query in gerrit

Related Objects
Search...

Event Timeline

matmarex created this task.Jul 29 2015, 9:01 PM
matmarex raised the priority of this task from to Needs Triage.
matmarex updated the task description. (Show Details)
matmarex added a project: OOUI.
matmarex added subscribers: matmarex, Mooeypoo.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2015, 9:01 PM
matmarex added a parent task: T69156: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari.Jul 29 2015, 9:03 PM
matmarex mentioned this in T69156: OOjs UI: Do not let me tab outside a dialog box in Chrome/Safari.
gerritbot subscribed.Sep 10 2015, 7:49 PM

Change 237480 had a related patch set uploaded (by Esanders):
Rewrite isFocusableElement for performance and correctness

https://gerrit.wikimedia.org/r/237480

gerritbot added a project: Patch-For-Review.Sep 10 2015, 7:49 PM
Jdforrester-WMF assigned this task to Esanders.Sep 10 2015, 9:21 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF set Security to None.
matmarex added a comment.Sep 10 2015, 9:50 PM

I appreciate the patch, but it does not seem to be fixing this bug.

Esanders added a comment.Sep 10 2015, 9:57 PM

I was going off your comment on the other bug that referenced this one. I'll reassign it to T69156...

Krenair subscribed.Sep 14 2015, 6:04 PM
matmarex added a comment.Sep 17 2015, 6:39 PM

Mmm… focusFirstFocusable is actually unused. The part which I observed not working is something even simpler (a :input selector) and even more broken.

gerritbot added a comment.Sep 17 2015, 7:05 PM

Change 239171 had a related patch set uploaded (by Bartosz Dziewoński):
BookletLayout, IndexLayout: Make autoFocus and focussing more reliable

https://gerrit.wikimedia.org/r/239171

gerritbot added a comment.Sep 21 2015, 11:28 AM

Change 239171 merged by jenkins-bot:
BookletLayout, IndexLayout: Make autoFocus and focussing more reliable

https://gerrit.wikimedia.org/r/239171

matmarex mentioned this in rGOJUac61d8d7ad62: BookletLayout, IndexLayout: Make autoFocus and focussing more reliable.Sep 21 2015, 11:28 AM
Jdforrester-WMF closed this task as Resolved.Sep 21 2015, 2:52 PM
Jdforrester-WMF edited projects, added OOjs-UI-next-release; removed Patch-For-Review.
Jdforrester-WMF edited projects, added OOUI (OOjs-UI-0.12.9), MW-1.27-release (WMF-deploy-2015-09-29_(1.27.0-wmf.1)); removed OOjs-UI-next-release.Sep 22 2015, 8:19 PM
Jdforrester-WMF moved this task from Backlog to Reviewing on the OOUI board.Nov 21 2015, 2:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL