Beta page banner (lead image) shouldn't be loaded with images disabled
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 29 2015, 10:50 PM

Description

Disable images via Special:MobileOptions then visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein
Notice the banner is present:
Expected: It shouldn't be.

Acceptance criteria:

Banner should not be loaded.
Add browser tests for image disabled functionality

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	WPB show no banner when images disabled	mediawiki/extensions/WikidataPageBanner	master	+93 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T103967 Bug: Lead image shows and then immediately hides when there's no image to display
Resolved	Florian	T106749 Mobile: Cannot turn off loading of images
Declined	None	T98145 [EPIC] Lead images (WikidataPageBanner integration) to stable
Resolved	Jdlrobson	T109484 [EPIC]: Mobile UI improvements
Resolved	Jdlrobson	T101108 Switch lead image in beta out for WikidataPageBanner
Resolved	Jdlrobson	T107368 Beta page banner (lead image) shouldn't be loaded with images disabled
Resolved	Jdlrobson	T98032 Mobile page banner experiment is clashing with WikidataPageBanner
Declined	Jdlrobson	T90698 Lead image should be delivered as part of the initial response
Declined	None	T98146 Create an API to get the lead image for an article
Declined	None	T98147 Create an API to set page props
Resolved	• KHammerstein	T98616 bug - Lead image should not have margins on screens less than 893
Resolved	Jdlrobson	T101036 Spike: What is a sensible threshold for treating content like a desktop browser?
Duplicate	None	T97319 bug - lead image should only be displayed on tablet when original image is minimum 768 px
Duplicate	None	T102156 Lead image - change crops to taller height so that less faces are cropped

Event Timeline

Jdlrobson created this task.Jul 29 2015, 10:50 PM

Jdlrobson raised the priority of this task from to Needs Triage.

Jdlrobson updated the task description. (Show Details)

Jdlrobson added a project: Web-Team-Backlog-Archived.

Jdlrobson added subscribers: Jdlrobson, gerritbot, Aklapper, • bmansurov.

Jdlrobson renamed this task from Beta page banner shouldn't be loaded with images disabled to Beta lead image shouldn't be loaded with images disabled.Jul 30 2015, 5:19 PM

Jdlrobson set Security to None.

• Jhernandez renamed this task from Beta lead image shouldn't be loaded with images disabled to Beta page banner (lead image) shouldn't be loaded with images disabled.Jul 30 2015, 5:20 PM

• Jhernandez triaged this task as High priority.

• Jhernandez edited projects, added Reading-Web-Sprint-52-Zoolander; removed Web-Team-Backlog-Archived.

• KLans_WMF raised the priority of this task from High to Needs Triage.Jul 30 2015, 5:20 PM

Jdlrobson added a parent task: T98145: [EPIC] Lead images (WikidataPageBanner integration) to stable.Jul 30 2015, 5:20 PM

• KLans_WMF edited projects, added Web-Team-Backlog-Archived; removed Reading-Web-Sprint-52-Zoolander.Aug 3 2015, 4:13 PM

phuedx added a parent task: T101108: Switch lead image in beta out for WikidataPageBanner.Aug 7 2015, 6:46 PM

Jdlrobson moved this task from Incoming to Epics/Goals on the Web-Team-Backlog-Archived board.Aug 12 2015, 1:40 AM

• Jhernandez triaged this task as Medium priority.Aug 18 2015, 5:40 PM

• Jhernandez subscribed.

• Jhernandez added a parent task: T109484: [EPIC]: Mobile UI improvements.Aug 18 2015, 5:50 PM

• Jhernandez edited projects, added MobileFrontend; removed Web-Team-Backlog-Archived.Aug 18 2015, 5:52 PM

MaxSem mentioned this in T109870: Remove the Disable images functionality.Aug 21 2015, 5:59 PM