Page MenuHomePhabricator
Create Task
Maniphest T107395

Remove docroot:/images/mobile in favour of docroot:/static/images/mobile
Closed, ResolvedPublic
Actions

Description

/static/images was created in 145f5cea9f324137512101eb6f42458c91bfe40c as copy of /images/, and the latter was left behind as stale copy (not a symlink).

Some of the files in there are now out of sync. For example, wikipedia-wordmark-en.png has a registered trademark icon in /static/images/mobile/ the version in /images/mobile does not.

They also don't benefit from the cache rules set up for /static.

https://en.m.wikipedia.org/static/images/mobile/wikipedia-wordmark-en.png
https://en.m.wikipedia.org/images/mobile/wikipedia-wordmark-en.png

mobile static Screen Shot 2015-07-02 at 05.16.10.png (922×1 px, 229 KB)

Details

SubjectRepoBranchLines +/-
Update mobile config to use /static/images instead of deprecated /imagesoperations/mediawiki-configmaster+20 -16
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Jul 30 2015, 12:40 AM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added projects: Web-Team-Backlog, acl*sre-team, Performance-Team.
Krinkle added subscribers: Krinkle, Jdlrobson, ori.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptJul 30 2015, 12:40 AM
Krinkle added a parent task: T86993: Static image files from en.m.wikipedia.org are served with cache-suppressing headers.Jul 30 2015, 12:44 AM
• KLans_WMF moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Jul 30 2015, 5:19 PM
Dzahn added a project: Mobile.Aug 3 2015, 2:07 PM
Dzahn set Security to None.
Jdlrobson removed a project: Web-Team-Backlog.Sep 3 2015, 4:56 PM
jcrespo triaged this task as Low priority.Sep 8 2015, 9:09 AM
jcrespo subscribed.

Low because it is "a nice thing to do" (aka #TODO), but it is not breaking something right now (feel free to correct me).

Krinkle updated the task description. (Show Details)Sep 8 2015, 2:18 PM
Krinkle added a comment.EditedSep 8 2015, 2:20 PM

The main impact from this is organisational overhead (they are outdated copies, possibly sending the wrong versions of production site logos to users), and minor performance impact because this is a non-standard top-level directory not declared anywhere in our traffic rules.

It's not benefitting gzip (which negatively impacts user bandwidth use for all files in this directory), and it's not benefitting cache collapsing from Varnish for de-duplication across domains. Which is set up for /static.

I agree it's not high priority, though.

@Jdlrobson: I tagged Web-Team-Backlog as I don't feel comfortable updating use of these files myself. They are different and have diverged since. I don't know to what extent those changes were intentional.

Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Sep 8 2015, 2:25 PM
gerritbot subscribed.Feb 13 2016, 9:35 AM

Change 270471 had a related patch set uploaded (by Krinkle):
Update mobile config to use /static/images instead of deprecated /images

https://gerrit.wikimedia.org/r/270471

gerritbot added a project: Patch-For-Review.Feb 13 2016, 9:35 AM
gerritbot added a comment.Feb 21 2016, 2:19 AM

Change 270471 merged by jenkins-bot:
Update mobile config to use /static/images instead of deprecated /images

https://gerrit.wikimedia.org/r/270471

Stashbot subscribed.Feb 21 2016, 2:37 AM

Mentioned in SAL [2016-02-21T02:37:20Z] <krinkle@tin> Synchronized wmf-config/InitialiseSettings.php: T107395 (duration: 01m 29s)

Krinkle closed this task as Resolved.Feb 21 2016, 2:38 AM
Krinkle claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL