Page MenuHomePhabricator
Create Task
Maniphest T107508

UploadWizard file upload status runs into action button
Closed, ResolvedPublic
Actions

Description

It appears that the "mwe-upwiz-file-endchoice" element could use a little room next to the action button.

I noticed this on Wikimedia Commons today.

Continue-button-chrome.png (152×316 px, 10 KB)
- Safari on OS X Yosemite

Continue-button-safari.png (128×320 px, 11 KB)
- Chrome on OS X Yosemite

Retry-button-safari.png (139×455 px, 13 KB)
- Safari on OS X Yosemite (different action label)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/UploadWizardmaster+37 -15Move file upload status labels from PHP to JS, and display them better
mediawiki/extensions/UploadWizardmaster+4 -0Add needed whitespace between buttons and text in UploadWizard
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ckoerner created this task.Jul 30 2015, 9:53 PM
Ckoerner raised the priority of this task from to Needs Triage.
Ckoerner updated the task description. (Show Details)
Ckoerner added a project: UploadWizard.
Ckoerner added a subscriber: Ckoerner.
Restricted Application added a project: Multimedia. · View Herald TranscriptJul 30 2015, 9:53 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
matmarex claimed this task.Jul 31 2015, 9:29 PM
matmarex triaged this task as Medium priority.
matmarex set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptJul 31 2015, 9:29 PM
matmarex added a subtask: T107868: Implement a FlowLayout/HorizontalLayout, that would arrange its contents in a single line.Aug 4 2015, 12:42 PM
gerritbot added a subscriber: gerritbot.Aug 4 2015, 6:26 PM

Change 229183 had a related patch set uploaded (by Bartosz Dziewoński):
Move file upload status labels from PHP to JS, and display them better

https://gerrit.wikimedia.org/r/229183

gerritbot added a project: Patch-For-Review.Aug 4 2015, 6:26 PM
matmarex mentioned this in T101617: Upload wizard buttons are green.Aug 6 2015, 10:46 AM
matmarex added a subscriber: Josve05a.Aug 6 2015, 10:48 AM
gerritbot added a comment.Aug 6 2015, 10:48 AM

Change 229607 had a related patch set uploaded (by Bartosz Dziewoński):
Add needed whitespace between buttons and text in UploadWizard

https://gerrit.wikimedia.org/r/229607

gerritbot added a comment.Aug 6 2015, 10:50 AM

Change 229607 merged by jenkins-bot:
Add needed whitespace between buttons and text in UploadWizard

https://gerrit.wikimedia.org/r/229607

matmarex mentioned this in rEUWI74be35dedd0c: Add needed whitespace between buttons and text in UploadWizard.Aug 6 2015, 10:50 AM
kaldari mentioned this in rMEXT7d0c1512b955: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Aug 6 2015, 10:51 AM
matmarex closed this task as Resolved.Aug 6 2015, 10:53 AM
matmarex added a subscriber: kaldari.

Resolved by @kaldari's patch above. My patch is just cleanup now.

Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 6 2015, 11:00 AM
Jdforrester-WMF closed subtask T107868: Implement a FlowLayout/HorizontalLayout, that would arrange its contents in a single line as Resolved.Aug 6 2015, 3:11 PM
gerritbot added a comment.Aug 12 2015, 3:18 PM

Change 229183 merged by jenkins-bot:
Move file upload status labels from PHP to JS, and display them better

https://gerrit.wikimedia.org/r/229183

matmarex mentioned this in rMEXT0be4965110dd: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Aug 12 2015, 3:18 PM
matmarex mentioned this in rEUWIcae915a6dfb4: Move file upload status labels from PHP to JS, and display them better.
Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 12 2015, 4:00 PM
Jdforrester-WMF moved this task from Untriaged to Done on the Multimedia board.Sep 15 2015, 4:27 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL