Page MenuHomePhabricator

Consider removing the extra asterisk for the required parameters inside the template dialog
Open, LowPublic

Description

Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Template>Cite web

Observe that, for required parameters there is an asterisk just next to the parameter name and also one inside the textbox for it.

I think its okay to remove one. Right now, it looks a bit redundant

Event Timeline

Ryasmeen raised the priority of this task from to Needs Triage.
Ryasmeen updated the task description. (Show Details)
Ryasmeen added a project: VisualEditor.
Ryasmeen added subscribers: Ryasmeen, Aklapper.
Jdforrester-WMF renamed this task from Remove the extra asterisk for the required parameters inside the template dialog to Consider removing the extra asterisk for the required parameters inside the template dialog.Jul 31 2015, 4:53 PM
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF set Security to None.
Jdforrester-WMF moved this task from To Triage to Epics on the VisualEditor board.Aug 1 2015, 11:08 PM
Jdforrester-WMF moved this task from Epics to Freezer on the VisualEditor board.

Just asking for confirmation. Do you still want this asterisk removed because of the redundancy?

I am asking this because i will like to work on the task.

Just asking for confirmation. Do you still want this asterisk removed because of the redundancy?

This task is not "remove the second asterisk", it's "do a piece of design research to work out whether removing one of the asterisks (and if so, which one) is a good move for our users", if that makes sense. If you'd like to study users to check on that it'd be cool, yes. :-)

Well, that makes sense though. The problem now is doing the research. We can approach the situation this way.

  1. Either we remove the asterisk in the input fields and see how the users respond to it after some time and also put it back and remove that beside the label and see the reaction from users. Then we conclude based on the response.
  1. We can just do general research to see which one is better to all users(not MediaWiki to be specific).

But generally speaking as a web developer, the asterisk beside the labels is better since it is conventional and those in the input fields are not conventional in web developments.

Ankitashukla added a subscriber: Ankitashukla.

I will mentor this task

@Ankitashukla: Could you take a look at the GCI task please and help the student?

AndyTechGuy added a subscriber: AndyTechGuy.

I claimed this task on the GCI website

AndyTechGuy removed AndyTechGuy as the assignee of this task.Dec 16 2015, 8:48 PM

I've taken over the GCI task for this and it turns out it is not an "easy" task, as it seems that this is problem is coded into the actual editor - you can see this from other templates.
The asterisk appears because in the template, "cite web", the textbox has the field "required" set to "true" (which is obviously needed), but the the Visual Editor code makes the asterisk appear in both areas (title and textbox). I will see if I can contact an admin to fix this, because I don't believe I have the permissions to change this, but if I do, then I will continue.

Krinkle added a subscriber: Krinkle.

@Duckworld I believe you have misunderstood this task. This task is not about "Cite web" in particular. This task is not about which fields are marked as required. This task is about how we visually represent a field that is required.

You are correct that this is coded as part of VisualEditor. This task is marked as "Easy", intended for a category of users interested in entry-level tasks within software development for VisualEditor, this is not a task about editing templates on Wikipedia.

However, I will still remove the good first bug tag because this task is currently blocked on Design research.