Maniphest T107646

Merging anything using integer keys in extension registration is broken
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Aug 1 2015, 6:11 AM

Tags

Referenced Files

None

Subscribers

Description

As @Krenair and I recently learned, any array using integer keys (e.g. namespace ids) that is merged will have the keys reset due to the usage of array_merge. We need to use += in those cases.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	REL1_25	+159 -23	registration: Overhaul merging of globals
	mediawiki/core	master	+149 -23	registration: Overhaul merging of globals

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Krenair	T104898 Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state
		Resolved		Legoktm	T107646 Merging anything using integer keys in extension registration is broken

Event Timeline

Legoktm created this task.Aug 1 2015, 6:11 AM

Legoktm raised the priority of this task from to High.

Legoktm updated the task description. (Show Details)

Legoktm added a project: MediaWiki-Configuration.

Legoktm added subscribers: Legoktm, Krenair.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2015, 6:11 AM

Change 228450 had a related patch set uploaded (by Legoktm):
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/228450

gerritbot added a project: Patch-For-Review.Aug 1 2015, 7:40 AM

Legoktm claimed this task.Aug 1 2015, 7:45 AM

Paladox closed this task as Resolved.Aug 2 2015, 6:54 PM

Paladox set Security to None.

Patch hasn't been merged yet.

Change 228450 merged by jenkins-bot:
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/228450

Legoktm mentioned this in rMW1ebb0f565966: registration: Overhaul merging of globals.Aug 2 2015, 8:29 PM

Legoktm closed this task as Resolved.Aug 2 2015, 8:53 PM

Legoktm added a parent task: T104898: Replace wgVisualEditorNamespaces with a 2D array of namespace => enabled state.

• Forrestbot added projects: MW-1.26-release, WMF-deploy-2015-08-04_(1.26wmf17).Aug 2 2015, 9:00 PM

Change 237971 had a related patch set uploaded (by Legoktm):
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/237971

Change 237971 merged by jenkins-bot:
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/237971

Legoktm mentioned this in rMW8ffe2bb56795: registration: Overhaul merging of globals.Sep 23 2015, 7:03 PM

ReleaseTaggerBot added a project: MW-1.25-release.Sep 29 2015, 8:02 PM