Merging anything using integer keys in extension registration is broken
Closed, ResolvedPublic

Description

As @Krenair and I recently learned, any array using integer keys (e.g. namespace ids) that is merged will have the keys reset due to the usage of array_merge. We need to use += in those cases.

Legoktm created this task.Aug 1 2015, 6:11 AM
Legoktm updated the task description. (Show Details)
Legoktm raised the priority of this task from to High.
Legoktm added subscribers: Legoktm, Krenair.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2015, 6:11 AM

Change 228450 had a related patch set uploaded (by Legoktm):
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/228450

Legoktm claimed this task.Aug 1 2015, 7:45 AM
Paladox closed this task as Resolved.Aug 2 2015, 6:54 PM
Paladox set Security to None.
Legoktm reopened this task as Open.Aug 2 2015, 6:58 PM

Patch hasn't been merged yet.

Change 228450 merged by jenkins-bot:
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/228450

Change 237971 had a related patch set uploaded (by Legoktm):
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/237971

Change 237971 merged by jenkins-bot:
registration: Overhaul merging of globals

https://gerrit.wikimedia.org/r/237971