Page MenuHomePhabricator

Convert LQT topics for talk pages where {{#useliquidthreads:1}} was removed after a thread was created
Open, LowestPublic

Description

Please check if the conversion script is working in the following situation:

  1. Add {{#useliquidthreads:1}} to enable LQT
  2. Create a new thread using LQT
  3. Remove {{#useliquidthreads:1}} to disable LQT
  4. Run the script which converts from LQT to Flow
    • What happens to the thread? Is it converted properly? Is the page taken over by Flow?

Event Timeline

He7d3r created this task.Aug 1 2015, 1:55 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a project: StructuredDiscussions.
He7d3r added a subscriber: He7d3r.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 1 2015, 1:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

What happens to the thread?

Nothing. It's not accessible in context now (it still is directly linked), and it's not after conversion.

Is it converted properly? Is the page taken over by Flow?

It's not converted by the LQT->Flow conversion, and Flow will not take over the page as part of that. The page won't be affected at all.

The threads will still be accessible the same way when LQT is put in the [https://gerrit.wikimedia.org/r/#/c/228192/ | frozen state] we're planning.

This is not a good feature; Flow does not allow any user to make a board mostly-inaccessible like that (obviously, you can use deletion/etc., but that's a different matter).

The right approach for switching from LQT to old-style/regular talk pages (or Flow to old-style talk pages) is to move the LQT or Flow board out of the way, and start a wikitext page.

DannyH added a subscriber: DannyH.Aug 4 2015, 11:00 PM

@Mattflaschen What did we decide to do with this ticket?

I recommend we don't do it, at least not now.

They'll be just as (in)accessible after the LQT->Flow is done as they are now.

It's not impossible, since LQT lets you query on it (which is kind of weird, since LQT is no longer enabled on that page).

But I don't think it should be a priority.

List for posterity as requested by @Quiddity:

mysql:research@s3-analytics-slave [mediawikiwiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+-----------------------------------------------------------------------------------------------------------+
| page_namespace | page_title                                                                                                |
+----------------+-----------------------------------------------------------------------------------------------------------+
|              4 | Forum                                                                                                     |
|              5 | Support_desk                                                                                              |
|             13 | Random_page/Archive_1                                                                                     |
|            103 | NewUserMessage                                                                                            |
|            103 | CentralAuth                                                                                               |
|              3 | ^demon                                                                                                    |
|            103 | Approved_Revs                                                                                             |
|            103 | GlobalUserGroups                                                                                          |
|              5 | PD_help                                                                                                   |
|              3 | Jorm_(WMF)/LQT-Redesign-v2                                                                                |
|             90 | Talk:Article_feedback/Please_stop/reply_(55)                                                              |
|            103 | SocialProfile                                                                                             |
|            103 | FrequentPatternTagCloud                                                                                   |
|              1 | ResourceLoader/V2_testing                                                                                 |
|              0 | Sandbox                                                                                                   |
|            103 | SetupWiki                                                                                                 |
|            103 | ReassignEdits                                                                                             |
|              3 | McCouman                                                                                                  |
|              1 | Continuous_integration/Task_management                                                                    |
|              3 | Lieutenant_S._Reznov                                                                                      |
|              3 | Luis_Felipe_Schenone                                                                                      |
|             90 | Project:Support_desk/Image_rendering_not_working;_namespace_prefix_redirects_to_Special:Upload_page/reply |
|              1 | Outreachy                                                                                                 |
|              1 | Design                                                                                                    |
|              1 | MediaWiki-Vagrant                                                                                         |
|              1 | Flow_Portal/Basic_information                                                                             |
|              3 | AnankeBot                                                                                                 |
|              5 | Language_policy/Migration_list                                                                            |
|              3 | Rahul_Jekar_Aheshash                                                                                      |
|            103 | Site_Settings                                                                                             |
|              2 | Syum90/Workshop                                                                                           |
+----------------+-----------------------------------------------------------------------------------------------------------+
31 rows in set (0.44 sec)

Note the support desk one is Project_*talk*:Support_desk (the page for talking about the support desk), (which no longer uses LQT,, not the support desk (which still does/did). You can look up the numbers at https://git.wikimedia.org/blob/mediawiki%2Fcore.git/e56f7b6c63acbb579888c0abf1c70c06f296d612/includes%2FDefines.php#L61 .

He7d3r added a comment.Aug 5 2015, 2:51 PM

Could you run that query for other wikis too? I think there might be some on ptwikibooks, there could be others.
Also, I think I found that by following a link from Special:NewMessages, so the threads were still accessible before, but would not be in Echo after the conversion. And I would prefer to re-enable LQT before they are ignored during the conversion to Flow.

DannyH triaged this task as Lowest priority.Aug 5 2015, 5:12 PM
DannyH set Security to None.

For most of them, we look for where useliquidthreads:1 is missing (this could be omitted, or explicitly set to useliquidthreads:0.

The three wikis where it's enabled by default (strategywiki, sewikimedia, ptwikibooks) have different queries. There, it doesn't require a magic word, but it can still be disabled (e.g. https://pt.wikibooks.org/wiki/Utilizador_Discuss%C3%A3o:MediaWiki_default ), so it looks for LQT conversations where the page was explicitly disabled.

mysql:research@s3-analytics-slave [testwiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
Empty set (0.00 sec)
mysql:research@s3-analytics-slave [enwikinews]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
| page_namespace | page_title                                                                                                                                                   |
+----------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
|            102 | Researcher_claims_solution_to_P_vs_NP_math_problem                                                                                                           |
|             90 | Comments:The_infants_confiscated_in_ShaoYang,_China/Comments_from_feedback_form_-_"Oh_dear,what_a_world_we_live_i..."                                        |
|             90 | Comments:Police_arrest_train_passenger_for_a_16-hour_loud_cellphone_conversation/Comments_from_feedback_form_-_"The_lady_should_sue_amtrak_for..."/reply_(5) |
|             90 | Comments:6.8_earthquake_rocks_northeastern_coast_of_Papua_New_Guinea/More_Often_All_The_Time/reply_(3)                                                       |
|             90 | Comments:Jailbreak_ipad_2/cool                                                                                                                               |
+----------------+--------------------------------------------------------------------------------------------------------------------------------------------------------------+
5 rows in set (2.10 sec)
mysql:research@s3-analytics-slave [enwiktionary]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+---------------+
| page_namespace | page_title    |
+----------------+---------------+
|              4 | Sandbox       |
|              3 | Rising_Sun    |
|              3 | George_Animal |
|              3 | NHJG          |
+----------------+---------------+
4 rows in set (0.19 sec)
mysql:research@s3-analytics-slave [fiwikimedia]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
Empty set (0.00 sec)
mysql:research@s3-analytics-slave [huwiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+---------------------------+
| page_namespace | page_title                |
+----------------+---------------------------+
|              3 | Teemeah                   |
|              3 | Bennó                     |
|              3 | Szasza                    |
|              3 | CFC                       |
|              3 | Dencey                    |
|              3 | Módis_Ágnes_Vadszederke   |
|              3 | RepliCarter               |
|              3 | FoBe                      |
|              3 | Andrew69.                 |
|              3 | Szekelyga                 |
|              3 | Nyiffi                    |
|              3 | Istvánka/Archívum22       |
|              3 | MarkAHershberger          |
|              3 | Tacsipacsi                |
|              3 | Bonbatya                  |
+----------------+---------------------------+
15 rows in set (0.02 sec)

(MediaWiki.org is apparently the same, but including it anyway, since it's a slightly different query).

mysql:research@s3-analytics-slave [mediawikiwiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+-----------------------------------------------------------------------------------------------------------+
| page_namespace | page_title                                                                                                |
+----------------+-----------------------------------------------------------------------------------------------------------+
|              4 | Forum                                                                                                     |
|              5 | Support_desk                                                                                              |
|             13 | Random_page/Archive_1                                                                                     |
|            103 | NewUserMessage                                                                                            |
|            103 | CentralAuth                                                                                               |
|              3 | ^demon                                                                                                    |
|            103 | Approved_Revs                                                                                             |
|            103 | GlobalUserGroups                                                                                          |
|              5 | PD_help                                                                                                   |
|              3 | Jorm_(WMF)/LQT-Redesign-v2                                                                                |
|             90 | Talk:Article_feedback/Please_stop/reply_(55)                                                              |
|            103 | SocialProfile                                                                                             |
|            103 | FrequentPatternTagCloud                                                                                   |
|              1 | ResourceLoader/V2_testing                                                                                 |
|              0 | Sandbox                                                                                                   |
|            103 | SetupWiki                                                                                                 |
|            103 | ReassignEdits                                                                                             |
|              3 | McCouman                                                                                                  |
|              1 | Continuous_integration/Task_management                                                                    |
|              3 | Lieutenant_S._Reznov                                                                                      |
|              3 | Luis_Felipe_Schenone                                                                                      |
|             90 | Project:Support_desk/Image_rendering_not_working;_namespace_prefix_redirects_to_Special:Upload_page/reply |
|              1 | Outreachy                                                                                                 |
|              1 | Design                                                                                                    |
|              1 | MediaWiki-Vagrant                                                                                         |
|              1 | Flow_Portal/Basic_information                                                                             |
|              3 | AnankeBot                                                                                                 |
|              5 | Language_policy/Migration_list                                                                            |
|              3 | Rahul_Jekar_Aheshash                                                                                      |
|            103 | Site_Settings                                                                                             |
|              2 | Syum90/Workshop                                                                                           |
+----------------+-----------------------------------------------------------------------------------------------------------+
31 rows in set (0.39 sec)
mysql:research@s3-analytics-slave [ptwikibooks]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 0 LIMIT 1000;
Empty set (0.17 sec)
mysql:research@s3-analytics-slave [strategywiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 0 LIMIT 1000;
+----------------+------------------+
| page_namespace | page_title       |
+----------------+------------------+
|              3 | HenkvD           |
|              3 | HenkvD           |
|              3 | TeleComNasSprVen |
|              3 | Hydroxonium      |
|              3 | Samal2010        |
+----------------+------------------+
5 rows in set (0.02 sec)
mysql:research@s3-analytics-slave [sewikimedia]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 0 LIMIT 1000;
Empty set (0.01 sec)
mysql:research@s3-analytics-slave [svwikisource]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+------------------------------------------+
| page_namespace | page_title                               |
+----------------+------------------------------------------+
|              4 | Mötesplatsen                             |
|              3 | Thurs/Arkiv/Historik_för_användarsidan   |
|              3 | Thurs                                    |
|              2 | Thurs/Stamsånger                         |
+----------------+------------------------------------------+
4 rows in set (0.30 sec)
mysql:research@s3-analytics-slave [test2wiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
+----------------+------------+
| page_namespace | page_title |
+----------------+------------+
|              3 | Werdna     |
+----------------+------------+
1 row in set (0.12 sec)
mysql:research@s3-analytics-slave [wikimania2010wiki]> SELECT page_namespace, page_title FROM thread JOIN page on thread_article_id = page_id LEFT OUTER JOIN page_props ON page_id = pp_page AND pp_propname = 'use-liquid-threads' AND pp_value = 1 WHERE pp_page IS NULL AND page_title NOT LIKE '%/LQT_Archive_1' GROUP by page_id LIMIT 1000;
Empty set (0.00 sec)
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptOct 12 2019, 4:17 AM