Page MenuHomePhabricator
Create Task
Maniphest T107677

HHVM's filter_var_array does not behave like the PHP5 function causing wikimedia/slimapp tests to fail
Closed, ResolvedPublic
Actions

Description

https://integration.wikimedia.org/ci/job/php-composer-test-hhvm/1488/consoleFull

23:28:58 1) Wikimedia\Slimapp\FormTest::testMultipleInputs
23:28:58 Failed asserting that Array &0 (
23:28:58     'bool' => ''
23:28:58     'true' => true
23:28:58     'email' => 'user!user2+route@example.wiki'
23:28:58     'float' => 1.23
23:28:58     'int' => 123
23:28:58     'ipv4' => '127.0.0.1'
23:28:58     'ipv6' => '::1'
23:28:58     'regex' => 'abc'
23:28:58     'url' => 'proto://host.tld/path'
23:28:58     'str' => 'one two three'
23:28:58 ) is identical to Array &0 (
23:28:58     'bool' => false
23:28:58     'true' => true
23:28:58     'email' => 'user!user2+route@example.wiki'
23:28:58     'float' => 1.23
23:28:58     'int' => 123
23:28:58     'ipv4' => '127.0.0.1'
23:28:58     'ipv6' => '::1'
23:28:58     'regex' => 'abc'
23:28:58     'url' => 'proto://host.tld/path'
23:28:58     'str' => 'one two three'
23:28:58 ).
23:28:58 
23:28:58 /mnt/jenkins-workspace/workspace/php-composer-test-hhvm/tests/FormTest.php:118

Details

SubjectRepoBranchLines +/-
Revert "Disable hhvm tests for wikimedia/slimapp"integration/configmaster+2 -9
Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULToperations/debs/hhvmmaster+120 -0
Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULToperations/debs/hhvmmaster+119 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Aug 1 2015, 11:43 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: WMF-General-or-Unknown, HHVM.
Legoktm added subscribers: Legoktm, bd808.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2015, 11:43 PM
Legoktm assigned this task to bd808.Aug 1 2015, 11:43 PM
Legoktm set Security to None.
bd808 added a project: Upstream.Aug 2 2015, 4:04 AM

Filed upstream as filter_var_array returns unexpected results for FILTER_VALIDATE_BOOLEAN and falsly values.

bd808 mentioned this in T90086: Create a framework library from the common components of Wikimania Scholarships and Grants review app.Aug 2 2015, 4:17 AM
Legoktm mentioned this in rCICFef743ae9e45a: Disable hhvm tests for wikimedia/slimapp.Aug 2 2015, 4:29 AM
bd808 added a comment.Aug 3 2015, 11:06 PM

I have a pull request in with HHVM to fix their broken handling of falsey booleans filter_var_array(). Until that's fix we have disabled hhvm testing in jenkins and travis for the library.

bd808 triaged this task as Low priority.Aug 3 2015, 11:07 PM
bd808 renamed this task from wikimedia/slimapp tests fail on HHVM to HHVM's filter_var_array does not behave like the PHP5 function.Aug 10 2015, 7:42 PM
Legoktm renamed this task from HHVM's filter_var_array does not behave like the PHP5 function to HHVM's filter_var_array does not behave like the PHP5 function causing wikimedia/slimapp tests to fail.Aug 10 2015, 7:54 PM
bd808 added a subscriber: Joe.Aug 24 2015, 10:23 PM

My fix has been merged upstream in HHVM with https://github.com/facebook/hhvm/commit/f2fb726fef23c082c220779d2831ec50bc0abf99.

@Joe I'll ask my perennial question again: do we have a process for requesting a backport of an upstream HHVM change into the WMF build?

bd808 added a project: User-bd808.Aug 24 2015, 10:23 PM
bd808 moved this task from To Do to Needs Review/Feedback on the User-bd808 board.
bd808 moved this task from Backlog to Defect on the HHVM board.Aug 24 2015, 10:28 PM
TheDJ moved this task from Backlog to Patch merged upstream on the Upstream board.Sep 1 2015, 12:20 PM
gerritbot subscribed.Sep 9 2015, 12:57 AM

Change 237006 had a related patch set uploaded (by BryanDavis):
Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULT

https://gerrit.wikimedia.org/r/237006

gerritbot added a project: Patch-For-Review.Sep 9 2015, 12:57 AM
gerritbot added a comment.Sep 11 2015, 11:41 PM

Change 237861 had a related patch set uploaded (by BryanDavis):
Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULT

https://gerrit.wikimedia.org/r/237861

gerritbot added a comment.Sep 11 2015, 11:44 PM

Change 237006 abandoned by BryanDavis:
Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULT

Reason:
Fixed missing Change-Id with Ie821948552152e542a0875667c7d99e7b7aaaf9b

https://gerrit.wikimedia.org/r/237006

Joe added a comment.Sep 15 2015, 10:14 AM

@bd808 no we don't, and I'm starting to think we need something like that. I'll think about how to do that in phabricator if possible.

gerritbot added a comment.Sep 15 2015, 10:17 AM

Change 237861 merged by Giuseppe Lavagetto:
Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULT

https://gerrit.wikimedia.org/r/237861

Joe mentioned this in rODAZecd7ce914a45: Backport of D44265: filter_var_array: do not fall back to FILTER_DEFAULT.Sep 15 2015, 10:23 AM
Joe added a parent task: T112640: Package and deploy HHVM 3.6.5+dfsg1-1+wm7.Sep 15 2015, 10:47 AM
Joe added a comment.Oct 5 2015, 2:55 PM

This patch has been deployed to production, can we consider this solved?

Joe closed this task as Resolved.Oct 5 2015, 2:55 PM
gerritbot added a comment.Oct 5 2015, 11:06 PM

Change 243828 had a related patch set uploaded (by Legoktm):
Revert "Disable hhvm tests for wikimedia/slimapp"

https://gerrit.wikimedia.org/r/243828

Legoktm added a comment.Oct 5 2015, 11:10 PM

Confirmed passing now: https://integration.wikimedia.org/ci/job/php-composer-test-hhvm/2114/console

gerritbot added a comment.Oct 6 2015, 4:03 AM

Change 243828 merged by jenkins-bot:
Revert "Disable hhvm tests for wikimedia/slimapp"

https://gerrit.wikimedia.org/r/243828

Legoktm mentioned this in rCICFa1631e1293b3: Revert "Disable hhvm tests for wikimedia/slimapp".Oct 6 2015, 4:04 AM
bd808 moved this task from Needs Review/Feedback to Done on the User-bd808 board.Nov 4 2015, 4:41 AM
bd808 moved this task from Done to Archive on the User-bd808 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL