Hi please allow skins to also be tested to make sure they work. Just like extension can be tested using mwext-testextension script skins should also have its own test by both being able to have dependencies or just on its own.
Description
Description
Event Timeline
Comment Actions
We should probably try this on small skins and work up to big skins such as vector would be counted as a big skin because it is the default skin across mediawiki including Wikimedia.
Comment Actions
Change 228470 had a related patch set uploaded (by Paladox):
Allow skins to also be tested like extensions can
Comment Actions
Do you know any skin, that has unit tests (phpunit)? I don't know any, which would make these tests useless?
Comment Actions
??? I think we misunderstood :) That was a question :P What tests should run for skins? Skins itself (at least the ones I know) doesn't provide any unit tests, so running unit tests on them would be pointless. Ok, there is one test, SideBarTest from which we could, maybe, benefit. But I'm not sure, if we should create unit tests for each skin to run this test on it.
Comment Actions
Running the mwext-testextension isent for unit tests it test the extension like all the code to make sure it works. This should do it on the skin too to make sure it works correctly.
Comment Actions
Hä? And how should a jenkins job doing that? I'm pretty sure, that mwext-testextension-{hhvm|zend} runs the phpunit test group extensions ;)
Comment Actions
Hum I am not sure then because I see extensions that doint even have test folder running the mwext-testextension test and they work.
Comment Actions
See https://git.wikimedia.org/summary/mediawiki%2Fextensions%2Fexamples which isent running any unit tests yet it run the mwext test
Comment Actions
Sure, the test group extensions runs some generic tests, mostly structure tests, see:
https://github.com/wikimedia/mediawiki/blob/master/tests/phpunit/suite.xml#L41-L46
Skins doesn't have these generic tests (only the one I mentioned before, SideBarTest.