Page MenuHomePhabricator
Create Task
Maniphest T107755

Move helper banner functions to WikidataPageBannerFunctions
Closed, ResolvedPublic
Actions

Description

For clarity reasons, move helper methods from WikidataPageBanner hooks to WikidataPageBannerFunctions.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikidataPageBannermaster+196 -172WikidataPageBanner hygiene - move non-hook methods
Customize query in gerrit

Related Objects

Event Timeline

Sumit created this task.Aug 3 2015, 2:02 PM
Sumit raised the priority of this task from to Needs Triage.
Sumit updated the task description. (Show Details)
Sumit added a project: Wikidata-Page-Banner.
Sumit moved this task to June 26-July 18 on the Wikidata-Page-Banner board.
Sumit added subscribers: Sumit, Jdlrobson.
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 3 2015, 2:02 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sumit mentioned this in T107231: Security review of Ex:PageBanner.Aug 3 2015, 2:05 PM
Sumit renamed this task from Move banner parameters to a function to Move helper banner functions to WikidataPageBannerFunctions.Aug 5 2015, 2:47 PM
Sumit updated the task description. (Show Details)
Sumit removed a project: Wikidata.
Sumit set Security to None.
gerritbot added a subscriber: gerritbot.Aug 5 2015, 2:48 PM

Change 229389 had a related patch set uploaded (by Sumit):
WikidataPageBanner hygiene - move non-hook methods

https://gerrit.wikimedia.org/r/229389

gerritbot added a project: Patch-For-Review.Aug 5 2015, 2:48 PM
Ricordisamoa added a subscriber: Ricordisamoa.Aug 8 2015, 9:50 PM
gerritbot added a comment.Aug 10 2015, 11:08 PM

Change 229389 merged by jenkins-bot:
WikidataPageBanner hygiene - move non-hook methods

https://gerrit.wikimedia.org/r/229389

Sumit mentioned this in rMEXT7fd020100a04: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Aug 10 2015, 11:08 PM
Jdlrobson mentioned this in rEWDPeb0649896524: WikidataPageBanner hygiene - move non-hook methods.Aug 10 2015, 11:09 PM
Jdlrobson closed this task as Resolved.Aug 11 2015, 12:36 AM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL