Page MenuHomePhabricator
Create Task
Maniphest T107936

Track user interaction with map iframes
Closed, ResolvedPublic
Actions

Description

We can already do that for Wikivoyage, need to expand that to other types of maps.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
More reliable handling of WMA and WIWOSM buttonsMaxSemmediawiki/extensions/WikimediaEventswmf/1.26wmf23+37 -9
More reliable handling of WMA and WIWOSM buttonsMaxSemmediawiki/extensions/WikimediaEventswmf/1.26wmf22+37 -9
More reliable handling of WMA and WIWOSM buttonsMaxSemmediawiki/extensions/WikimediaEventsmaster+37 -9
Track interaction with WMA and WIWOSM mapsMaxSemmediawiki/extensions/WikimediaEventsmaster+13 -8
Customize query in gerrit

Related Objects

Event Timeline

MaxSem created this task.Aug 4 2015, 8:38 PM
MaxSem raised the priority of this task from to Needs Triage.
MaxSem updated the task description. (Show Details)
MaxSem added a project: Maps-Sprint.
MaxSem subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2015, 8:38 PM
MaxSem claimed this task.Aug 4 2015, 8:38 PM
MaxSem set Security to None.
MaxSem moved this task from Backlog to In progress on the Maps-Sprint board.
Aklapper added a comment.Aug 5 2015, 10:20 AM

Where could I read about the underlying motivation to "track user interaction"?

MaxSem added a comment.Aug 5 2015, 10:12 PM

@Aklapper, https://www.mediawiki.org/wiki/Maps#Key_Performance_Indicators

gerritbot subscribed.Aug 5 2015, 10:13 PM

Change 229586 had a related patch set uploaded (by MaxSem):
Track interaction with WMA and WIWOSM maps

https://gerrit.wikimedia.org/r/229586

gerritbot added a project: Patch-For-Review.Aug 5 2015, 10:13 PM
MaxSem moved this task from In progress to Needs review on the Maps-Sprint board.Aug 5 2015, 10:14 PM
• ksmith added subscribers: Krinkle, • ksmith.Aug 20 2015, 5:27 PM

@MaxSem: Please flesh out this task description to explain what the patch is trying to accomplish, and how it can be tested.

@Krinkle can you review the patch?

Krinkle added a comment.Aug 20 2015, 7:37 PM

I can't review https://gerrit.wikimedia.org/r/229586 and not sure I should.

The commit doesn't specify what it is supposed to do (commit message), and I personally have no experience with neither the code being changed nor the gadgets it is instrumenting, or how to test locally that this works.

What I can see is that the current master version of ext.wikimediaEvents.geoFeatures.js in the WikimediaEvents repo already has code to track WikiMiniAtlas (WMA), WIWOSM and Wikivoyage. This new commit doesn't appear to change that code much, the commit mostly does some arbitrary refactoring – yet the commit message says it introduces the tracking, but it was already there. Presumably it doesn't work? Please specify why it didn't work, and (more importantly) why the new version does work.

MaxSem added a comment.Aug 20 2015, 8:35 PM

The patch doesn't do anything that's not required to add the trackIframe() calls that it adds. Anyway, Yuri will review it.

gerritbot added a comment.Aug 26 2015, 11:28 PM

Change 229586 merged by jenkins-bot:
Track interaction with WMA and WIWOSM maps

https://gerrit.wikimedia.org/r/229586

MaxSem mentioned this in rEWMVfffccc3deae9: Track interaction with WMA and WIWOSM maps.Aug 26 2015, 11:28 PM
Diffusion mentioned this in rMEXTf608b1872204: Updated mediawiki/extensions Project: mediawiki/extensions/WikimediaEvents….Aug 26 2015, 11:28 PM
• Forrestbot added a project: WMF-deploy-2015-09-01_(1.26wmf21).Aug 27 2015, 12:00 AM
gerritbot added a comment.Sep 11 2015, 12:17 AM

Change 237546 had a related patch set uploaded (by MaxSem):
More reliable handling of WMA and WIWOSM buttons

https://gerrit.wikimedia.org/r/237546

gerritbot added a comment.Sep 15 2015, 9:09 PM

Change 237546 merged by jenkins-bot:
More reliable handling of WMA and WIWOSM buttons

https://gerrit.wikimedia.org/r/237546

Yurik closed this task as Resolved.Sep 15 2015, 9:09 PM
Yurik subscribed.
Diffusion mentioned this in rMEXTa7b64cadaf77: Updated mediawiki/extensions Project: mediawiki/extensions/WikimediaEvents….Sep 15 2015, 9:10 PM
MaxSem mentioned this in rEWMVce8e2ba5d07b: More reliable handling of WMA and WIWOSM buttons.Sep 15 2015, 9:10 PM
Yurik moved this task from Needs review to Done on the Maps-Sprint board.Sep 15 2015, 9:14 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 15 2015, 10:00 PM
gerritbot added a comment.Sep 15 2015, 10:02 PM

Change 238617 had a related patch set uploaded (by MaxSem):
More reliable handling of WMA and WIWOSM buttons

https://gerrit.wikimedia.org/r/238617

gerritbot added a comment.Sep 15 2015, 10:03 PM

Change 238618 had a related patch set uploaded (by MaxSem):
More reliable handling of WMA and WIWOSM buttons

https://gerrit.wikimedia.org/r/238618

gerritbot added a comment.Sep 15 2015, 11:36 PM

Change 238617 merged by jenkins-bot:
More reliable handling of WMA and WIWOSM buttons

https://gerrit.wikimedia.org/r/238617

gerritbot added a comment.Sep 15 2015, 11:36 PM

Change 238618 merged by jenkins-bot:
More reliable handling of WMA and WIWOSM buttons

https://gerrit.wikimedia.org/r/238618

MaxSem mentioned this in rMWf1f18ecc4f1b: Updated mediawiki/core Project: mediawiki/extensions/WikimediaEvents….Sep 15 2015, 11:36 PM
MaxSem mentioned this in rMW866106d6c365: Updated mediawiki/core Project: mediawiki/extensions/WikimediaEvents….
MaxSem mentioned this in rEWMVab470c737354: More reliable handling of WMA and WIWOSM buttons.
MaxSem mentioned this in rEWMVd5a7ba17c7b1: More reliable handling of WMA and WIWOSM buttons.
ReleaseTaggerBot added projects: WMF-deploy-2015-09-08_(1.26wmf22), WMF-deploy-2015-09-15_(1.26wmf23).Sep 16 2015, 12:01 AM
Yurik added a project: Maps.Nov 7 2015, 7:34 AM
Restricted Application added a project: Discovery-ARCHIVED. · View Herald TranscriptNov 7 2015, 7:34 AM
Restricted Application added a subscriber: StudiesWorld. · View Herald Transcript
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits