Page MenuHomePhabricator

Fix $wmgEchoSiteNotificationIconUrl
Closed, DuplicatePublic

Description

Follow up to T48585: Wikipedia icon is shown for other sites

'wmgEchoSiteNotificationIconUrl' => array(
	'default' => false, // Placeholder icon
	'enwiki' => '//upload.wikimedia.org/wikipedia/commons/f/ff/Wikipedia_Echo_notification_icon.png', // https://commons.wikimedia.org/wiki/File:Wikipedia_Echo_notification_icon.png
),
  • W icon can be set for all Wikipedias probably
  • Icon should be using /static/ stuff
  • Set up icons for all other projects

Event Timeline

Legoktm created this task.Aug 4 2015, 10:10 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Legoktm.
Restricted Application added subscribers: Matanya, Aklapper. · View Herald TranscriptAug 4 2015, 10:10 PM

Is this only shown on the welcome notification? If so, can we reuse the icons in w/static/apple-touch/ or /w/static/favicon/ if they are in the correct size?

Is this only shown on the welcome notification?

Anything which sets 'icon' => 'site' which is welcome and user rights change currently.

If so, can we reuse the icons in w/static/apple-touch/ or /w/static/favicon/ if they are in the correct size?

They should be 30x30 icons according to the documentation.