Page MenuHomePhabricator

Minerva skin HTML should be consistent with Vector skin HTML
Closed, ResolvedPublic

Description

In mobile skin:
#content_wrapper should be changed to #content
and #content to #bodyContent

Existing uses of the #content element should be evaluated carefully
$ ag -a '#content' resources/

Do not break cached page HTML!

Event Timeline

Do not break cached page HTML!

Jdlrobson claimed this task.Aug 6 2015, 6:28 PM
Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-53-12-Monkeys board.

Change 229937 had a related patch set uploaded (by Jdlrobson):
Make Minerva skin more consistent with Vector

https://gerrit.wikimedia.org/r/229937

Jhernandez closed this task as Resolved.Aug 10 2015, 12:27 PM
Jhernandez added a subscriber: bmansurov.

Verified in Beta cluster.

@Jdlrobson @bmansurov I'm not sure but it seems like the patch (based on the commit message) is doing more things than what the description of this task specifies. This is rolling out tomorrow, please verify anything other than #content and #bodyContent on Beta Cluster today!

If there's more stuff changed please updating the phab description would be useful too.

I did some testing on labs and I didn't find any issues.

There should be no fallback. The additional changes were just weakening some overly specific existing css rules.