In mobile skin:
#content_wrapper should be changed to #content
and #content to #bodyContent
Existing uses of the #content element should be evaluated carefully
$ ag -a '#content' resources/
Do not break cached page HTML!
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T96785 In-channel feedback with star rating / picklist (and on apps, simple text entry?) and backend de-spam | |||
| Resolved | • Jhernandez | T104439 [GOAL]: Develop a mechanism for quick surveys on desktop + mobile | |||
| Duplicate | None | T107594 An enabled configured external survey shows on the desktop site. | |||
| Resolved | • bmansurov | T107589 An enabled configured external survey shows on the mobile version of the site | |||
| Resolved | Jdlrobson | T107592 An enabled configured quick survey shows on the mobile version of the site | |||
| Resolved | Jdlrobson | T108075 Minerva skin HTML should be consistent with Vector skin HTML |
Event Timeline
Comment Actions
Change 229937 had a related patch set uploaded (by Jdlrobson):
Make Minerva skin more consistent with Vector
Comment Actions
Verified in Beta cluster.
@Jdlrobson @bmansurov I'm not sure but it seems like the patch (based on the commit message) is doing more things than what the description of this task specifies. This is rolling out tomorrow, please verify anything other than #content and #bodyContent on Beta Cluster today!
If there's more stuff changed please updating the phab description would be useful too.
Comment Actions
There should be no fallback. The additional changes were just weakening some overly specific existing css rules.