Page MenuHomePhabricator

Undefined index "laplace" in Hooks.php
Closed, ResolvedPublic

Description

Spotted in production:

Notice: Undefined index: laplace in /srv/mediawiki/php-1.26wmf17/extensions/CirrusSearch/includes/Hooks.php on line 359

Seems it can easily happen under default settings because $wgCirrusSearchPhraseSuggestProfiles['default'] lacks a 'laplace' entry. Sounds like it should either get one, or the calling code be updated to check for the variable prior to using it.

Event Timeline

demon created this task.Aug 6 2015, 4:06 PM
demon raised the priority of this task from to Normal.
demon updated the task description. (Show Details)
demon added a project: CirrusSearch.
demon added a subscriber: demon.
Restricted Application added a project: Discovery. · View Herald TranscriptAug 6 2015, 4:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
dcausse claimed this task.Aug 6 2015, 4:11 PM
dcausse set Security to None.

Change 229747 had a related patch set uploaded (by DCausse):
Fix Undefined index: laplace

https://gerrit.wikimedia.org/r/229747

Should be fixed, sorry.

Change 229747 merged by jenkins-bot:
Fix Undefined index: laplace

https://gerrit.wikimedia.org/r/229747

demon added a comment.Aug 6 2015, 6:00 PM

No worries, thanks for the quick fix!

Change 229864 had a related patch set uploaded (by 20after4):
Fix Undefined index: laplace

https://gerrit.wikimedia.org/r/229864

Change 229864 merged by jenkins-bot:
Fix Undefined index: laplace

https://gerrit.wikimedia.org/r/229864

Umherirrender closed this task as Resolved.Aug 10 2015, 6:51 PM