Page MenuHomePhabricator

MobileFrontend has 'reporttime' and 'bottomscripts' reversed
Closed, ResolvedPublic


Compared to Vector, Monobook, the fallback and API skins and most other skins, Mobile has the footer in a different order.

On desktop:

  • jQuery.ready
  • mw.loader.state
  • mw.loader.load
  • mw.config.set({"wgBackendResponseTime ..

On mobile:

  • mw.config.set({"wgBackendResponseTime ..
  • jQuery.ready
  • mw.loader.state
  • mw.loader.load

It should swap data['reporttime'] and data['bottomscripts']. Or perhaps use the printTrail() from BaseTemplate class which does this automatically (instead of hardcoding).

Event Timeline

Krinkle created this task.Aug 6 2015, 5:04 PM
Krinkle raised the priority of this task from to Needs Triage.
Krinkle updated the task description. (Show Details)
Krinkle added a project: Readers-Web-Backlog.
Krinkle added a subscriber: Krinkle.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2015, 5:04 PM

@Krinkle Does this have any practical effects? Is it skewing any performance metrics?

Just trying to clarify the urgency of this :)

Krinkle triaged this task as Low priority.Aug 6 2015, 5:15 PM
Krinkle added a project: Technical-Debt.
Krinkle set Security to None.
Krinkle added a comment.EditedAug 6 2015, 6:37 PM

@Jhernandez It isn't causing any problems that I can measure at this time. However load and execution order are sensitive areas in an application that should not needlessly vary between desktop and mobile. It can bite us unexpectedly later. Especially because these variables (reporttime, bottomscripts) are quite generic and have been repurposed and extended a lot over time. It's quite likely people make assumptions about their order in the HTML stream.

Florian claimed this task.Aug 6 2015, 9:27 PM

Change 229963 had a related patch set uploaded (by Florianschmidtwelzow):
Use default order of footer elements

Change 229963 merged by jenkins-bot:
Use default order of footer elements

Florian closed this task as Resolved.Aug 7 2015, 5:29 AM

Thanks for the explanation @Krinkle.

Thanks @Florian for the patch! Awesome