Page MenuHomePhabricator

Newsletter Extension: Unit testing
Closed, ResolvedPublic

Description

As of now, unit testing is scheduled to start right after we are done with the ''To be closed" tasks in MediaWiki-extensions-Newsletter

Event Timeline

Tinaj1234 claimed this task.
Tinaj1234 raised the priority of this task from to Medium.
Tinaj1234 updated the task description. (Show Details)
Tinaj1234 added subscribers: Tinaj1234, Qgil, 01tonythomas.

Change 231599 had a related patch set uploaded (by Tinaj1234):
Unit testing for Newsletter extension

https://gerrit.wikimedia.org/r/231599

Change 231599 merged by jenkins-bot:
Unit testing for Newsletter extension

https://gerrit.wikimedia.org/r/231599

Okey - even though we have merged one of the relevant unit test, I dont think we can close this now - as we still can/should have more unit tests. For the scope of GSoC 2015, I will move this to 'Backlog' than 'To be closed at the Earliest'.

When do we know that we are done with the "legacy" code ;) , meaning the code written during GSoC? In other words, when can we close this task?

New unit tests should come together with the new code, right? As in we don't close a feature-related task as Resolved until the related unit tests are provided.

I think this task can be closed. We have more than one unit test merged as of now, so I think it's safe to close this one.

*agrees* the code is also more testable now that before.
And we are only going to introduce more tests! ;)