It seems
mw.mobileFrontend.emit( 'history-link-loaded' )
is getting executed before the last modified code loads.
Thus the last modified bar doesn't get enhanced.
Bug is present on all wikis including English Wikipedia.
Description
Description
Details
Details
Related Gerrit Patches:
| mediawiki/extensions/MobileFrontend : master | Queue mobile head inline scripts with Resource Loader |
| mediawiki/extensions/MobileFrontend : master | Init last modified when the module is loaded |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • rmoen | T101344 [EPIC] Push max-width and last modified work for mobile on desktop to stable | |||
| Resolved | • rmoen | T104697 [Stable] Move the last modified bar to the bottom of the page | |||
| Resolved | • rmoen | T108204 Regression: Last modified bar code not running in async mode |
Event Timeline
Comment Actions
Change 229859 had a related patch set uploaded (by Robmoen):
Init last modified when the module is loaded
Comment Actions
The old patch has been abandoned. Do we have a link to the new one?
Edit: https://gerrit.wikimedia.org/r/#/c/230653/
Comment Actions
I've commented on the original patch with why I figured we should revert this. The tldr is changing HTML can cause us lots of headaches, and we should make sure we're 100% right when we do it (I actually think at least 2 people should review an HTML change but not sure if that's actually feasible)
@Jhernandez it's worth noting that it seems having the last modified bar in 2 places is causing confusion and solving where it should live (T104697) might make fixing this a lot easier.
Comment Actions
@Jdlrobson That one and its friends will be tackled next sprint or sprint 4, I've prioritized it higher to find it later.
Comment Actions
Change 231188 had a related patch set uploaded (by Robmoen):
Queue mobile head inline scripts with Resource Loader
Comment Actions
Change 231188 merged by jenkins-bot:
Queue mobile head inline scripts with Resource Loader
Comment Actions
Seems to work fine on beta cluster in beta and stable. Not sure how the broken state of it looked like since there's little info on the bug description. I'm considering it done.
Comment Actions
@Jhernandez, the broken message looks something like this: "Last modified on 14 August 2015, at 15:12". You can currently see it on enwiki [1].
[1] https://en.m.wikipedia.org/w/index.php?title=Barack_Obama&mobileaction=toggle_view_mobile