Page MenuHomePhabricator
Create Task
Maniphest T108204

Regression: Last modified bar code not running in async mode
Closed, ResolvedPublic
Actions

Description

It seems

mw.mobileFrontend.emit( 'history-link-loaded' )

is getting executed before the last modified code loads.
Thus the last modified bar doesn't get enhanced.

Bug is present on all wikis including English Wikipedia.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendmaster+23 -20Queue mobile head inline scripts with Resource Loader
mediawiki/extensions/MobileFrontendmaster+11 -13Init last modified when the module is loaded
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 6 2015, 5:19 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Reading-Web-Sprint-53-12-Monkeys, MobileFrontend.
Jdlrobson moved this task to Needs Analysis on the Reading-Web-Sprint-53-12-Monkeys board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a project: Readers-Web-Backlog. · View Herald TranscriptAug 6 2015, 5:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson renamed this task from Last modified bar code not running in async mode to Regression: Last modified bar code not running in async mode.Aug 6 2015, 5:19 PM
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-53-12-Monkeys board.
Jdlrobson set Security to None.
Jhernandez raised the priority of this task from High to Unbreak Now!.Aug 6 2015, 5:25 PM
Jhernandez removed a project: Readers-Web-Backlog.
• rmoen claimed this task.Aug 6 2015, 6:00 PM
• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-53-12-Monkeys board.
gerritbot added a subscriber: gerritbot.Aug 6 2015, 7:08 PM

Change 229859 had a related patch set uploaded (by Robmoen):
Init last modified when the module is loaded

https://gerrit.wikimedia.org/r/229859

gerritbot added a project: Patch-For-Review.Aug 6 2015, 7:08 PM
• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 6 2015, 7:09 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 6 2015, 8:19 PM
• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 6 2015, 8:28 PM
Jdlrobson updated the task description. (Show Details)Aug 7 2015, 5:54 PM
Jdlrobson moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 6:36 PM
Jdlrobson mentioned this in T108045: Various mobile module dependencies on stale cached pages in production for some non logged in users.Aug 10 2015, 6:58 PM
gerritbot added a comment.Aug 10 2015, 9:25 PM

Change 229859 abandoned by Robmoen:
Init last modified when the module is loaded

https://gerrit.wikimedia.org/r/229859

• rmoen moved this task from -1 (Needs More Work) to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 9:26 PM
bmansurov added a subscriber: bmansurov.EditedAug 10 2015, 10:56 PM

The old patch has been abandoned. Do we have a link to the new one?
Edit: https://gerrit.wikimedia.org/r/#/c/230653/

bmansurov moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 11:18 PM
bmansurov added a comment.Aug 10 2015, 11:46 PM

Reverted in https://gerrit.wikimedia.org/r/#/c/230704/

bmansurov moved this task from Ready for Signoff to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 10 2015, 11:47 PM
Jdlrobson added a subscriber: Jhernandez.Aug 10 2015, 11:56 PM

I've commented on the original patch with why I figured we should revert this. The tldr is changing HTML can cause us lots of headaches, and we should make sure we're 100% right when we do it (I actually think at least 2 people should review an HTML change but not sure if that's actually feasible)

@Jhernandez it's worth noting that it seems having the last modified bar in 2 places is causing confusion and solving where it should live (T104697) might make fixing this a lot easier.

Jhernandez added a comment.Aug 11 2015, 11:08 AM

@Jdlrobson That one and its friends will be tackled next sprint or sprint 4, I've prioritized it higher to find it later.

• rmoen moved this task from -1 (Needs More Work) to To Do on the Reading-Web-Sprint-53-12-Monkeys board.Aug 11 2015, 4:44 PM
• rmoen removed • rmoen as the assignee of this task.Aug 12 2015, 8:58 PM
• rmoen claimed this task.Aug 12 2015, 10:31 PM
• rmoen moved this task from To Do to Doing on the Reading-Web-Sprint-53-12-Monkeys board.
gerritbot added a comment.Aug 12 2015, 10:55 PM

Change 231188 had a related patch set uploaded (by Robmoen):
Queue mobile head inline scripts with Resource Loader

https://gerrit.wikimedia.org/r/231188

• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 12 2015, 10:56 PM
bmansurov moved this task from Code Review to -1 (Needs More Work) on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 5:53 PM
Jhernandez added a parent task: T104697: [Stable] Move the last modified bar to the bottom of the page.Aug 13 2015, 7:37 PM
• rmoen moved this task from -1 (Needs More Work) to Doing on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 8:10 PM
• rmoen moved this task from Doing to Code Review on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 8:21 PM
gerritbot added a comment.Aug 13 2015, 8:30 PM

Change 231188 merged by jenkins-bot:
Queue mobile head inline scripts with Resource Loader

https://gerrit.wikimedia.org/r/231188

• rmoen mentioned this in rEMFR74394b6ce9f5: Queue mobile head inline scripts with Resource Loader.Aug 13 2015, 8:30 PM
Diffusion mentioned this in rMEXT9f9a02473a63: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Aug 13 2015, 8:31 PM
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-53-12-Monkeys board.Aug 13 2015, 8:47 PM
Forrestbot added a project: WMF-deploy-2015-08-18_(1.26wmf19).Aug 13 2015, 9:00 PM
Jhernandez closed this task as Resolved.Aug 14 2015, 10:25 AM

Seems to work fine on beta cluster in beta and stable. Not sure how the broken state of it looked like since there's little info on the bug description. I'm considering it done.

Jhernandez moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-53-12-Monkeys board.Aug 14 2015, 10:25 AM
bmansurov added a comment.Aug 14 2015, 5:08 PM

@Jhernandez, the broken message looks something like this: "Last modified on 14 August 2015, at 15:12". You can currently see it on enwiki [1].

[1] https://en.m.wikipedia.org/w/index.php?title=Barack_Obama&mobileaction=toggle_view_mobile

Jhernandez added a comment.Aug 17 2015, 9:11 AM

Thanks @bmansurov. Confirmed :D

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL