Page MenuHomePhabricator
Create Task
Maniphest T108216

Indented pre blocks just broken
Closed, ResolvedPublic
Actions

Description

We have a rule for this (pre_indent_in_tags) but it looks pathological and I'm going to disable it for now because it doesn't match (the end tag isn't reachable).

<pre class="123">hi</pre>

parses as,

<pre><pre class="123">hi</pre></pre>

but in php,

<pre class="123">hi</pre>

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Treat html pre and nowiki as extension tagsArlolramediawiki/services/parsoidmaster+271 -327
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Aug 6 2015, 6:54 PM
Arlolra raised the priority of this task from to Medium.
Arlolra updated the task description. (Show Details)
Arlolra added projects: Parsoid, Parsoid-Tokenizer.
Arlolra subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2015, 6:54 PM
gerritbot subscribed.Aug 6 2015, 7:01 PM

Change 229857 had a related patch set uploaded (by Arlolra):
T108216: Disable pre_indent_in_tags rule for now

https://gerrit.wikimedia.org/r/229857

gerritbot added a project: Patch-For-Review.Aug 6 2015, 7:01 PM
Arlolra updated the task description. (Show Details)Aug 7 2015, 4:00 AM
Arlolra removed a project: Patch-For-Review.
Arlolra set Security to None.
gerritbot added a comment.Aug 7 2015, 4:00 AM

Change 229857 merged by jenkins-bot:
T108216: Disable pre_indent_in_tags rule for now

https://gerrit.wikimedia.org/r/229857

Arlolra mentioned this in rGPAR465b1a91f0c0: T108216: Disable pre_indent_in_tags rule for now.Aug 7 2015, 4:01 AM
gerritbot added a comment.Jan 20 2017, 1:48 AM

Change 281076 had a related patch set uploaded (by Arlolra):
WIP: Treat html pre and nowiki as an extension tag

https://gerrit.wikimedia.org/r/281076

gerritbot added a project: Patch-For-Review.Jan 20 2017, 1:48 AM
Arlolra claimed this task.Jan 20 2017, 1:49 AM
gerritbot added a comment.Feb 7 2017, 6:44 PM

Change 281076 merged by jenkins-bot:
Treat html pre and nowiki as extension tags

https://gerrit.wikimedia.org/r/281076

Arlolra closed this task as Resolved.Feb 7 2017, 6:53 PM
Stashbot mentioned this in T58381: Change DOM rendering of <nowiki /> to be <span typeof="mw:Nowiki"></span> or similar?.Feb 14 2017, 6:39 PM
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-02-14T18:39:24Z] <arlolra> Updated Parsoid to 79ccfb93 (T58381, T108216)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits