Page MenuHomePhabricator

Normalize currency_code to uppercase
Closed, ResolvedPublic1 Story Points

Description

We should be able to accept lowercase currency codes from incoming links and normalize them to upper case. Currently we treat lowercase as an unsupported currency, show an error, and make the user choose an amount an currency.

Event Timeline

Ejegg created this task.Aug 6 2015, 8:43 PM
Ejegg claimed this task.
Ejegg raised the priority of this task from to Needs Triage.
Ejegg updated the task description. (Show Details)
Ejegg added a subscriber: Ejegg.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2015, 8:43 PM

Is this related to Astropay?

Change 229948 had a related patch set uploaded (by Ejegg):
Normalize currency_code to uppercase

https://gerrit.wikimedia.org/r/229948

Ejegg added a comment.Aug 6 2015, 8:54 PM

Yep @atgo, it's the main reason for those ffname errors.

Awesome. Should we pull this into sprint?

Might as well - the code's already written!

atgo set Security to None.

Change 229948 merged by jenkins-bot:
Normalize currency_code to uppercase

https://gerrit.wikimedia.org/r/229948

Ejegg closed this task as Resolved.Aug 6 2015, 9:55 PM
Ejegg moved this task from Pending Deployment to Done on the Fundraising Sprint Queen board.
Ejegg edited a custom field.