Page MenuHomePhabricator
Create Task
Maniphest T108272

JavaScript error from ext.cx.campaigns.contributionsmenu missing dependency on mediawiki.Uri
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I loaded http://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dido_Sotiriou&useskin=monobook&debug=1 , and in my browser console was the error

TypeError: mw.Uri is not a function
http://en.wikipedia.beta.wmflabs.org/static/master/extensions/ContentTranslation/modules/campaigns/ext.cx.campaigns.contributionsmenu.js
Line 14

The 'ext.cx.campaigns.contributionsmenu' module loads this JavaScript file, but ContentTranslation/extension.js does not declare its dependency on mediawiki.Uri. This allowed mediawiki.Uri.js to happen to load after ext.cx.campaigns.contributionsmenu.js in debug mode, so fail. Easy fix.

https://www.mediawiki.org/wiki/ResourceLoader/Developing_with_ResourceLoader#Debugging says "It is important to test your code in both debug and production modes." :-)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add missing dependency to ext.cx.campaigns.contributionsmenumediawiki/extensions/ContentTranslationmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

• Spage created this task.Aug 7 2015, 12:05 AM
• Spage raised the priority of this task from to High.
• Spage updated the task description. (Show Details)
• Spage added projects: ContentTranslation-Analytics, ContentTranslation.
• Spage subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2015, 12:05 AM
• Spage added a project: good first task.Aug 7 2015, 12:18 AM
gerritbot subscribed.Aug 7 2015, 1:11 AM

Change 230027 had a related patch set uploaded (by KartikMistry):
Add missing dependency to ext.cx.campaigns.contributionsmenu

https://gerrit.wikimedia.org/r/230027

gerritbot added a project: Patch-For-Review.Aug 7 2015, 1:11 AM
santhosh assigned this task to KartikMistry.Aug 7 2015, 3:33 AM
santhosh added a project: LE-CX6-Sprint 1.
santhosh set Security to None.
santhosh moved this task from Backlog to In Review on the LE-CX6-Sprint 1 board.
santhosh subscribed.
gerritbot added a comment.Aug 7 2015, 3:35 AM

Change 230027 merged by jenkins-bot:
Add missing dependency to ext.cx.campaigns.contributionsmenu

https://gerrit.wikimedia.org/r/230027

KartikMistry mentioned this in rMEXT64a0d5b8a51f: Updated mediawiki/extensions Project: mediawiki/extensions/ContentTranslation….Aug 7 2015, 3:35 AM
KartikMistry mentioned this in rECTX45c690d9a9af: Add missing dependency to ext.cx.campaigns.contributionsmenu.
• Forrestbot added a project: WMF-deploy-2015-08-11_(1.26wmf18).Aug 7 2015, 4:00 AM
KartikMistry closed this task as Resolved.Aug 7 2015, 5:55 AM
KartikMistry edited a custom field.
KartikMistry moved this task from In Review to Done on the LE-CX6-Sprint 1 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits