Especially those relating to content handler:
- CONTENT_MODEL_XXX
- CONTENT_FORMAT_XXX
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | |
|---|---|---|---|---|
| · · · | ||||
| Resolved | Tpt | T87962 Convert ProofreadPage to use extension registration | ||
| Declined | None | T108285 Allow defining constants in extension registration | ||
| · · · |
Event Timeline
Comment Actions
Ok, I think the most consistent thing would be to convert the ContentHandlers section to an object, like it is for namespaces, and allow to set the constant there. However, this would be a breaking change, as far as I can see, and would probably be a feature for manifest_version 2. On the other hand: There aren't so much extensions, which use the ContentHandlers feature at the moment (https://github.com/search?l=JSON&q=%40wikimedia+ContentHandlers&type=Code&utf8=%E2%9C%93), so I think it would be possible to convert them. What do you think @Legoktm?
Comment Actions
Change 325120 had a related patch set uploaded (by Florianschmidtwelzow):
WIP: registration: Add possibility to set CONTENT_MODEL_ and CONTENT_FORMAT_ constants
Comment Actions
Change 325120 abandoned by Florianschmidtwelzow:
WIP: registration: Add possibility to set CONTENT_MODEL_ and CONTENT_FORMAT_ constants
Reason:
Sounds reasonable. Should we decline the phabricator task with a message that the values should be used directly, or class constants should be used? :)