Page MenuHomePhabricator

[Task] Remove "wb-entity-spinner"
Closed, ResolvedPublic


We should entirely remove the spinner that used to appear while we were re-doing the entity DOM. We no longer do that for quite some time now and the spinner has moved to entityViewInit by now.

I guess the spinner doesn't show up in a lot of cases any more and if it does, probably not for very long.

Event Timeline

hoo raised the priority of this task from to Needs Triage.
hoo updated the task description. (Show Details)
hoo added subscribers: hoo, Lydia_Pintscher, Jonas and 2 others.

The new way we invoke the spinner apparently (people told me and I perceive this myself, I have no solid numbers on this) also slows down page rendering, another case for killing it.

It's shifting stuff, it appears after some part of the page loaded, it's annoying!

thiemowmde renamed this task from Remove "wb-entity-spinner" to [Task] Remove "wb-entity-spinner".Aug 13 2015, 4:55 PM
thiemowmde triaged this task as High priority.
thiemowmde added a project: patch-welcome.
thiemowmde moved this task from incoming to consider for next sprint on the Wikidata board.

Personally I agree that it should be removed with no replacement (for now). You could even say that it does the opposite: it makes the fact that some pages load slow even more visible. The spinner itself is not really a problem, but the code dims the whole page and this causes two additional refreshs in the browser.

Change 232246 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Remove entity view loading spinner

Change 232246 merged by jenkins-bot:
Remove entity view loading spinner

Addshore closed this task as Resolved.EditedAug 18 2015, 9:12 AM
Addshore claimed this task.
Addshore subscribed.

Merged, will be out with the next branch & deploy