Page MenuHomePhabricator
Create Task
Maniphest T108408

Page actions in mobile skin should appear below the WikidataPageBanner page banner
Closed, ResolvedPublic
Actions

Description

Design feedback from @kaity - I think page action icons (edit and watch) should be below the banner. The text can wrap around them, so there won't be a lot of wasted space.

wikivoyage-11.png (549×1 px, 282 KB)

In addition to this when this extension is enabled, we shouldnt' attempt to load our own banners in MobileFrontend.

Details

SubjectRepoBranchLines +/-
Do not add banner inside #bodyContentmediawiki/extensions/WikidataPageBannermaster+79 -28
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Aug 7 2015, 11:47 PM
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Wikidata-Page-Banner, MobileFrontend.
Jdlrobson moved this task to Blocked on the Wikidata-Page-Banner board.
Jdlrobson subscribed.
Restricted Application added projects: Web-Team-Backlog, Wikidata. · View Herald TranscriptAug 7 2015, 11:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson updated the task description. (Show Details)Aug 7 2015, 11:47 PM
Jdlrobson set Security to None.
Jdlrobson moved this task from Incoming to 2015-16 Q4 on the Web-Team-Backlog board.Aug 10 2015, 5:58 PM
Jdlrobson moved this task from Blocked to Backlog on the Wikidata-Page-Banner board.Aug 12 2015, 5:46 AM
Jdlrobson removed a project: Web-Team-Backlog.Aug 14 2015, 11:28 PM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Aug 17 2015, 3:47 PM
Jdlrobson moved this task from Backlog to Epics on the Wikidata-Page-Banner board.Aug 30 2015, 5:02 PM
Jdlrobson merged a task: T105127: Banners between search and last-edited on Skin Minerva.
Jdlrobson added subscribers: Nicolas_Raoul, Sumit.
gerritbot subscribed.Sep 16 2015, 12:28 AM

Change 238654 had a related patch set uploaded (by Jdlrobson):
Do not add banner inside #bodyContent

https://gerrit.wikimedia.org/r/238654

gerritbot added a project: Patch-For-Review.Sep 16 2015, 12:28 AM
Jdlrobson claimed this task.Sep 16 2015, 12:31 AM
Jdlrobson triaged this task as Medium priority.Sep 16 2015, 5:20 PM
gerritbot added a comment.Sep 18 2015, 3:53 PM

Change 238654 merged by jenkins-bot:
Do not add banner inside #bodyContent

https://gerrit.wikimedia.org/r/238654

• Konfused-Kitten mentioned this in rMEXTa0eb271a2418: Updated mediawiki/extensions Project: mediawiki/extensions/WikidataPageBanner….Sep 18 2015, 3:53 PM
• Konfused-Kitten mentioned this in rEWDP4dfbe5069732: Do not add banner inside #bodyContent.Sep 18 2015, 3:55 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 18 2015, 5:00 PM
Jdlrobson closed this task as Resolved.EditedSep 23 2015, 7:35 PM

Can't verify on beta labs given that maintaining support with the Wikivoyage config is currently more important (we have no beta wikivoyage labs :)).

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL