If we loaded mediawiki.legacy.commonPrint via a separate style tag with media="print", it wouldn't block rendering.
Description
Details
Related Objects
- Mentioned In
- rMW66cc4cb2708f: Load 'mediawiki.legacy.commonPrint' styles with a media type property
rMW11e47561e465: Load 'mediawiki.legacy.commonPrint' styles with a media type property - Mentioned Here
- T108727: IE9 executing our MediaWiki:Print.css stylesheet in screen media
T24256: Change printable link to JavaScript `print()`
T51722: ResourceLoader does not process media queries for printable view with JS-added CSS
Event Timeline
I think this is intentional so ?printable=yes works? See also T51722: ResourceLoader does not process media queries for printable view with JS-added CSS and T24256: Change printable link to JavaScript `print()`.
No, I misunderstood what this bug was about.
Should this be done for just media => print or all media types like screen, etc.?
Ideally all stylesheets which apply only to specific media will declare their media type. Practically speaking, the benefit will come almost entirely from splitting off media=print stylesheets into a separate link tag.
Change 230487 had a related patch set uploaded (by Legoktm):
Load 'mediawiki.legacy.commonPrint' styles with a media type property
I went with a very simple solution for now by creating a separate 'print' group, and modules that set it will use a separate <style media="print"> tag. This doesn't help for things like mediawiki.action.history.diff which has a media=>print style-sheet and a media=>all style-sheet.
Change 230487 merged by jenkins-bot:
Load 'mediawiki.legacy.commonPrint' styles with a media type property
Change 230575 had a related patch set uploaded (by Ori.livneh):
Load 'mediawiki.legacy.commonPrint' styles with a media type property
Change 230575 merged by jenkins-bot:
Load 'mediawiki.legacy.commonPrint' styles with a media type property